[coreboot] [patch][superiotool] Add w83527hg support

[Uwe Hermann]

Hi,

On Mon, Dec 13, 2010 at 06:46:23PM +0800, Bao, Zheng wrote:
> The datasheet is available on nuvoton's website.
> http://www.nuvoton.com/NuvotonMOSS/Community/ProductInfo.aspx?tp_GUID=cf
> 73485c-9e0a-4218-9bee-89dfe9a7bb87
> 
> 
> Signed-off-by: Zheng Bao <zheng.bao at amd.com>

With the changes below this is
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Please use this as commit message:

"Add dump support for the Winbond/Nuvoton W83527HG."


> Index: util/superiotool/winbond.c
> ===================================================================
> --- util/superiotool/winbond.c	(revision 6169)
> +++ util/superiotool/winbond.c	(working copy)
> @@ -345,6 +345,30 @@
>  		{EOT}}},
>  
>  	{0xb07, "W83527HG", {	/* TODO: Not yet in sensors-detect */
> +		{NOLDN, NULL,
> +
> {0x02,0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x28,0x29,
> +			 0x2a,0x2c,0x2d,0x2e,0x2f,EOT},
> +
> {0x00,0xB0,0x73,0xff,0x00,MISC,0x00,0x00,0x50,0x00,
> +			 0x00,0xe2,0x21,0x00,0x00,EOT}},

Please drop the 0x02 register, it's not useful and write-only anyway.
Not sure about 0x26, maybe that should be MISC.

Please add 0x27 and 0x2b as "RSVD" (registers explicitly mentioned in
the datasheet as reserved should be listed and marked RSVD).


> +		{0x5, "Keyboard",
> +			{0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT},
> +			{0x01,0x00,0x60,0x00,0x64,0x01,0x0c,0x83,EOT}},
> +		{0x8, "Watchdog timer",

"Watchdog timer" should probably be "WDTO#, PLED", that's more specific
and corresponds to the datasheet.


> +		{0xa, "ACPI",
> +
> {0x30,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,
> +			 0xf2,0xf3,0xf4,0xf6,0xf7,0xfe,EOT},
> +
> {0x00,0x00,0x00,0x00,NANA,NANA,0x00,0x00,0x1c,0x00,
> +			 0x7c,0x00,0x00,0x00,0x00,0x00,EOT}},

I think 0xe0 should have 0x01 as value, 0xe2 is 0xff, and 0xe3 is 0x08.
Please add 0xe8 and 0xe9 as RSVD.


> +		{0xb, "Hardware monitor",
> +			{0x30,0x60,0x61,0x70,0xf0,0xf2,EOT},
> +			{0x00,0x00,0x00,0x00,0x81,0x00,EOT}},

Please add 0xf1 as RSVD.


Also, LDN 0x0c (PECI) is missing I think, please add it.


Thanks, Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org