[coreboot] [PATCH] e7501 register pressure

Uwe Hermann uwe at hermann-uwe.de
Tue Feb 23 15:36:50 CET 2010


On Mon, Feb 22, 2010 at 04:30:20PM -0800, ron minnich wrote:
> On Mon, Feb 22, 2010 at 4:03 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
> 
> > Does anyone have the hardware?
> >
> 
> I doubt anyone does. The question here is, if no one can test it, are
> we better off making a change we can not test,

Yes.


> or removing the support.

No.


We have to live with the fact that we will never be able to test _all_
changes on hardware all the time. That doesn't mean we should stop
working on the code. We've been doing tree-wide changes in recent weeks
and months on a regular basis (high tables, cbfs, kconfig,
tinybootblock, and many many more) which have a _lot_ higher potential
for breaking (lots of!) boards than this patch. That doesn't mean we should
not have done those changes. At most we should try to carefully review
more of our patches and encourage more users to test on their boards
more often.

Yes, bugs may slip in, but they will be noticed next time someone tests
on hardware (or a user reports a bug on IRC or the list), and then we can
bisect and fix the bug. No big deal.

 
> Acked-by: Ronald G. Minnich <rminnich at gmail.com>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list