[coreboot] [PATCH]generic ssdt rules

Patrick Georgi patrick at georgi-clan.de
Sun Feb 28 23:12:29 CET 2010


Hi,

attached patch unifies the ACPI_SSDTX_NUM handling.

- define meaning for ACPI_SSDTX_NUM: highest ssdtX.asl to build
- add rules that build either 4 or 5 ssdts (which is what exists in the
tree now)
- change ACPI_SSDTX_NUM to either 4 or 5 for boards that have ssdtX.asl
files, according to the ssdtX.asl in there.
- remove custom ssdt rules

I checked the tree and didn't find any occurrence where the value of
ACPI_SSDTX_NUM was used for something else than a test for >= 1, so
changing the values (within this constraint) won't affect behaviour.

No idea what "31" was supposed to be good for, but it definitely doesn't
affect the build.

There is no simple way to do "greater than" tests in gnu make that I
found. One solution would be some recursive macro that adds ssdtX rules
for x down to 2 (ssdt1 doesn't exist by convention), which seems to
require building mathematical functions first, etc. That seemed to be
overkill for the three uses of the variable (which isn't even globally
defined)


Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100228-2-generic-ssdt-builds
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100228/3d157ddb/attachment.ksh>


More information about the coreboot mailing list