[coreboot] msrtool: Read both values in diff mode from file [was: coreboot and MSM800BEV]

[Stefan Reinauer]

Very nice!

Peter Stuge wrote:
> This also introduces a small change in the user interface for immediate
> mode (-i). Previously, whitespace could separate high and low words in
> an MSR as such:
>
> msrtool -i 4c00000f='f2f100ff 56960004'
>
> That is no longer allowed, a space character now ends the MSR value. Any
> other character can still be used as separator however, so the following
> syntax still works as expected:
>
> msrtool -i 4c00000f=f2f100ff:56960004
>
> Signed-off-by: Peter Stuge <peter at stuge.se>
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>

> Previously, msrtool would assume that MSR values should be compared
> between stored value in file and current value in hardware which msrtool
> was running on. This does not always fit the use case and with this
> change msrtool can now compare two sets of MSR values stored in a file.
> If only one MSR value is stored in the file, msrtool will behave as
> previously and read the second MSR value from hardware.
>
> This change means that msrtool does not always need access to the system
> MSR functions so it can now be run as a regular user when using diff
> mode with both MSR values stored in the file.
>
> Signed-off-by: Peter Stuge <peter at stuge.se>
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Best regards,
Stefan