[coreboot] [PATCH]Jetway PA78VM5

[Qing Pei Wang]

hi marc,
thanks a lot for your kindly review.
i update the patch followed by your suggestion.
there are some issues with all of the fam10 problems. patch will be send
later.

On Tue, Jul 20, 2010 at 5:19 AM, Marc Jones <marcj303 at gmail.com> wrote:

> On Thu, Jul 15, 2010 at 2:01 AM, Qing Pei Wang <wangqingpei at gmail.com>
> wrote:
> > hi all,
> >    in order to make the code much clear, i update the patch which sent
> > yesterday to make all messages fit for "PA78VM5".
> >
> > Signed-off-by Wang Qing Pei <wangqingpei at gmail.com>
> >
>
>
> Qing Pei,
>
> Can you break up this patch into smaller parts, fintek sio and
> mainboard? That would make it easier to review.
>
> Also, Can you give a summary of what the code supports. What works and
> what doesn't. What about internal graphics, pci e slots etc?
>
>
> Here are a few items to look at:
>
> Do you need the mb_sysconf.h file? I don't think that the 8132 and
> 8111 stuff is needed on your platform.
>
> In devicetree.cb, You don't need multiple 18.0 devices.
>
> romstage.c
> +//used by incoherent_ht
> +#define FAM10_SCAN_PCI_BUS 0
> +#define FAM10_ALLOCATE_IO_RANGE 0
>
> Are these used? I think that they may be outdated. Maybe make a patch
> for all fam10 platforms?
>
> +//#include "northbridge/amd/amdht/ht_wrapper.c"
> +//#include "northbridge/amd/amdfam10/raminit_amdmct.c"
> +//#include "cpu/amd/model_10xxx/fidvid.c"
> +//#include "spd_addr.h"
>
> Remove these old includes that are commented out.
>
> Remove spd_addr.h file since it isn't used.
>
> chip.h
> +//     int fixup_scsi;
> +//     int fixup_vga;
>
> Remove these old lines. I don't think that they are used for anything
> in 780/700.
>
> Marc
>
>
> --
> http://se-eng.com
>



-- 
Wang Qing Pei
Phone: 86+13426369984
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100720/b6eeeac9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f71863fg.patch
Type: text/x-patch
Size: 9820 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100720/b6eeeac9/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PA78VM5.patch
Type: text/x-patch
Size: 146859 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100720/b6eeeac9/attachment-0001.patch>