[coreboot] PATCH: Fix CMOS Tables support for all boards.

Myles Watson mylesgw at gmail.com
Fri Jun 25 21:54:14 CEST 2010


On Thu, Jun 24, 2010 at 7:08 AM, Edwin Beasant
<edwin_beasant at virtensys.com> wrote:
> Re-integrated the “USE_OPTION_TABLE” code so that it will compile for all
> boards that define it at configure time.
>
> Made USE_OPTION_TABLE dependant on HAVE_OPTION_TABLE
>
> Signed-off-by: Edwin Beasant edwin_beasant at virtensys.com
I updated your patch to:
- Have a default value for USE_OPTION_TABLE even when
HAVE_OPTION_TABLE isn't defined
- Pass abuild with USE_OPTION_TABLE defaulting to y or n

use_options.diff: Your patch, slightly modified
options_fixup.diff: Fix boards to include the .h file instead of the .c file
have_option_polarity.diff: Default to no cmos.layout file so it can be
selected (like most other options)

Patch for testing with USE_OPTION_TABLE defaulting to y
     use_option_default.diff

I think it would make sense to default to using the option table if it
is present.

A next step might be to remove the "default" parameter from
read_option and make it get the default from option_table.h.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_options.diff
Type: text/x-diff
Size: 4733 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100625/dbef2c97/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: options_fixup.diff
Type: text/x-diff
Size: 50010 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100625/dbef2c97/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: have_option_polarity.diff
Type: text/x-diff
Size: 57338 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100625/dbef2c97/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_option_default.diff
Type: text/x-diff
Size: 370 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100625/dbef2c97/attachment-0003.bin>


More information about the coreboot mailing list