[coreboot] PATCH: Fix CMOS Tables support for all boards.
edwin_beasant at virtensys.com
Wed Jun 30 19:52:29 CEST 2010
Seems best of all worlds to me :-)
Can we get an ack and a commit?
On 25 Jun 2010, at 20:54, Myles Watson wrote:
> On Thu, Jun 24, 2010 at 7:08 AM, Edwin Beasant
> <edwin_beasant at virtensys.com> wrote:
>> Re-integrated the “USE_OPTION_TABLE” code so that it will compile
>> for all
>> boards that define it at configure time.
>> Made USE_OPTION_TABLE dependant on HAVE_OPTION_TABLE
>> Signed-off-by: Edwin Beasant edwin_beasant at virtensys.com
> I updated your patch to:
> - Have a default value for USE_OPTION_TABLE even when
> HAVE_OPTION_TABLE isn't defined
> - Pass abuild with USE_OPTION_TABLE defaulting to y or n
> use_options.diff: Your patch, slightly modified
> options_fixup.diff: Fix boards to include the .h file instead of
> the .c file
> have_option_polarity.diff: Default to no cmos.layout file so it can be
> selected (like most other options)
> Patch for testing with USE_OPTION_TABLE defaulting to y
> I think it would make sense to default to using the option table if it
> is present.
> A next step might be to remove the "default" parameter from
> read_option and make it get the default from option_table.h.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
More information about the coreboot