[coreboot] [PATCH] Istanbul support

[Bao, Zheng]

index ac62981..067560d 100644
--- a/src/cpu/amd/quadcore/quadcore.c
+++ b/src/cpu/amd/quadcore/quadcore.c
@@ -69,11 +72,10 @@ static void real_start_other_core(u32 nodeid, u32
cores)
 
 	if(cores > 1) {
 		dword = pci_read_config32(NODE_PCI(nodeid, 0), 0x168);
-		dword |= (1 << 0);	// core2
-		if(cores > 2) {		// core3
-			dword |= (1 << 1);
+		for (i = 0; i < cores - 1; i++) {
+			dword |= 1 << i;
+			pci_write_config32(NODE_PCI(nodeid, 0), 0x168,
dword);
 		}
-		pci_write_config32(NODE_PCI(nodeid, 0), 0x168, dword);
 	}
 }

I assume the line
pci_write_config32(NODE_PCI(nodeid, 0), 0x168, dword);
should be put outside the loop.

Everything seems to be fine. I don't have Istanbul to test. I have read
every changes and they all look good.

Signed-off-by: Zheng Bao <zheng.bao at amd.com>



> -----Original Message-----
> From: coreboot-bounces at coreboot.org
[mailto:coreboot-bounces at coreboot.org]
> On Behalf Of Arne Georg Gleditsch
> Sent: Friday, March 05, 2010 10:41 PM
> To: coreboot at coreboot.org
> Subject: [coreboot] [PATCH] Istanbul support
> 
> Hi,
> 
> The following patch implements Opteron Fam 10 rev D (aka Istanbul)
> support for coreboot.  I have not updated MAX_CPUS for all fam10
> mainboards, but it might make sense to multiply those by 1.5.
> 
> Signed-off-by: Arne Georg Gleditsch <arne.gleditsch at numascale.com>
> 
> --
> 								Arne.