[coreboot] [Patch] remove some warnings

Myles Watson mylesgw at gmail.com
Wed Mar 17 22:33:09 CET 2010


1. gcc doesn't like a character array being cast to a struct.

-extern unsigned char AmlCode[];
+extern void* AmlCode;

2. Include <console/console.h> if you're using PRINTK_IN_CAR (not ROMCC)
3. Add a few more "nuisance" prototypes.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

I think it would be nice to add the number of warnings for each board on one
of the build pages.  It looks like there are many that could compile without
any warnings, and some that look like they have a few too many.  Here's the
list after this patch:

coreboot-builds/a-trend_atc-6220/make.log:2
coreboot-builds/a-trend_atc-6240/make.log:2
coreboot-builds/abit_be6-ii_v2_0/make.log:2
coreboot-builds/advantech_pcm-5820/make.log:76
coreboot-builds/amd_db800/make.log:111
coreboot-builds/amd_dbm690t/make.log:132
coreboot-builds/amd_mahogany/make.log:182
coreboot-builds/amd_mahogany_fam10/make.log:378
coreboot-builds/amd_norwich/make.log:110
coreboot-builds/amd_pistachio/make.log:127
coreboot-builds/amd_rumba/make.log:65
coreboot-builds/amd_serengeti_cheetah/make.log:74
coreboot-builds/amd_serengeti_cheetah_fam10/make.log:270
coreboot-builds/arima_hdama/make.log:49
coreboot-builds/artecgroup_dbe61/make.log:112
coreboot-builds/asi_mb_5blgp/make.log:2
coreboot-builds/asi_mb_5blmp/make.log:2
coreboot-builds/asus_a8n_e/make.log:54
coreboot-builds/asus_a8v-e_se/make.log:74
coreboot-builds/asus_m2v-mx_se/make.log:103
coreboot-builds/asus_mew-am/make.log:9
coreboot-builds/asus_mew-vm/make.log:10
coreboot-builds/asus_p2b-d/make.log:3
coreboot-builds/asus_p2b-ds/make.log:3
coreboot-builds/asus_p2b-f/make.log:2
coreboot-builds/asus_p2b-ls/make.log:2
coreboot-builds/asus_p2b/make.log:2
coreboot-builds/asus_p3b-f/make.log:2
coreboot-builds/axus_tc320/make.log:2
coreboot-builds/azza_pt-6ibd/make.log:2
coreboot-builds/bcom_winnet100/make.log:2
coreboot-builds/bcom_winnetp680/make.log:100
coreboot-builds/biostar_m6tba/make.log:2
coreboot-builds/broadcom_blast/make.log:78
coreboot-builds/compaq_deskpro_en_sff_p600/make.log:2
coreboot-builds/dell_s1850/make.log:5
coreboot-builds/digitallogic_adl855pc/make.log:10
coreboot-builds/digitallogic_msm586seg/make.log:12
coreboot-builds/digitallogic_msm800sev/make.log:111
coreboot-builds/eaglelion_5bcm/make.log:2
coreboot-builds/emulation_qemu-x86/make.log:0
coreboot-builds/gigabyte_ga-6bxc/make.log:2
coreboot-builds/gigabyte_ga_2761gxdk/make.log:128
coreboot-builds/gigabyte_m57sli/make.log:133
coreboot-builds/hp_dl145_g3/make.log:110
coreboot-builds/hp_e_vectra_p2706t/make.log:9
coreboot-builds/ibm_e325/make.log:48
coreboot-builds/ibm_e326/make.log:50
coreboot-builds/iei_juki-511p/make.log:2
coreboot-builds/iei_nova4899r/make.log:2
coreboot-builds/iei_pcisa-lx-800-r10/make.log:111
coreboot-builds/intel_d945gclf/make.log:24
coreboot-builds/intel_eagleheights/make.log:49
coreboot-builds/intel_jarrell/make.log:13
coreboot-builds/intel_mtarvon/make.log:6
coreboot-builds/intel_truxton/make.log:6
coreboot-builds/intel_xe7501devkit/make.log:15
coreboot-builds/iwill_dk8_htx/make.log:51
coreboot-builds/iwill_dk8s2/make.log:58
coreboot-builds/iwill_dk8x/make.log:53
coreboot-builds/jetway_j7f24/make.log:99
coreboot-builds/kontron_986lcd-m/make.log:15
coreboot-builds/kontron_kt690/make.log:131
coreboot-builds/lippert_frontrunner/make.log:42
coreboot-builds/lippert_roadrunner-lx/make.log:113
coreboot-builds/lippert_spacerunner-lx/make.log:114
coreboot-builds/mitac_6513wu/make.log:9
coreboot-builds/msi_ms6119/make.log:2
coreboot-builds/msi_ms6147/make.log:2
coreboot-builds/msi_ms6156/make.log:2
coreboot-builds/msi_ms6178/make.log:9
coreboot-builds/msi_ms7135/make.log:58
coreboot-builds/msi_ms7260/make.log:131
coreboot-builds/msi_ms9185/make.log:108
coreboot-builds/msi_ms9282/make.log:132
coreboot-builds/msi_ms9652_fam10/make.log:298
coreboot-builds/nec_powermate2000/make.log:9
coreboot-builds/newisys_khepri/make.log:48
coreboot-builds/nvidia_l1_2pvv/make.log:135
coreboot-builds/olpc_btest/make.log:72
coreboot-builds/olpc_rev_a/make.log:71
coreboot-builds/pcengines_alix1c/make.log:112
coreboot-builds/rca_rm4100/make.log:1
coreboot-builds/roda_rk886ex/make.log:25
coreboot-builds/soyo_sy-6ba-plus-iii/make.log:2
coreboot-builds/sunw_ultra40/make.log:59
coreboot-builds/supermicro_h8dme/make.log:126
coreboot-builds/supermicro_h8dmr/make.log:124
coreboot-builds/supermicro_h8dmr_fam10/make.log:293
coreboot-builds/supermicro_h8qme_fam10/make.log:293
coreboot-builds/supermicro_x6dai_g/make.log:13
coreboot-builds/supermicro_x6dhe_g/make.log:17
coreboot-builds/supermicro_x6dhe_g2/make.log:9
coreboot-builds/supermicro_x6dhr_ig/make.log:6
coreboot-builds/supermicro_x6dhr_ig2/make.log:6
coreboot-builds/technexion_tim5690/make.log:130
coreboot-builds/technexion_tim8690/make.log:130
coreboot-builds/technologic_ts5300/make.log:10
coreboot-builds/televideo_tc7020/make.log:2
coreboot-builds/thomson_ip1000/make.log:0
coreboot-builds/tyan_s1846/make.log:2
coreboot-builds/tyan_s2735/make.log:78
coreboot-builds/tyan_s2850/make.log:52
coreboot-builds/tyan_s2875/make.log:50
coreboot-builds/tyan_s2880/make.log:54
coreboot-builds/tyan_s2881/make.log:53
coreboot-builds/tyan_s2882/make.log:51
coreboot-builds/tyan_s2885/make.log:49
coreboot-builds/tyan_s2891/make.log:58
coreboot-builds/tyan_s2892/make.log:4
coreboot-builds/tyan_s2895/make.log:49
coreboot-builds/tyan_s2912/make.log:136
coreboot-builds/tyan_s2912_fam10/make.log:298
coreboot-builds/tyan_s4880/make.log:53
coreboot-builds/tyan_s4882/make.log:44
coreboot-builds/via_epia-cn/make.log:48
coreboot-builds/via_epia-m/make.log:135
coreboot-builds/via_epia-m700/make.log:204
coreboot-builds/via_epia-n/make.log:132
coreboot-builds/via_epia/make.log:62
coreboot-builds/via_pc2500e/make.log:45
coreboot-builds/via_vt8454c/make.log:60
coreboot-builds/winent_pl6064/make.log:110

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100317/38f51b13/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warning.diff
Type: text/x-patch
Size: 12067 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100317/38f51b13/attachment.diff>


More information about the coreboot mailing list