[coreboot] [PATCH] make AMD CAR disable a C function

Rudolf Marek r.marek at assembler.cz
Sun May 16 18:46:34 CEST 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

Following patch reworks car_disable into C. Tested, works here. I compared
also the GCC generated code and it looks all right. Please test on some
multicore CPU.

I added the "memory" clobber to read_cr0 / write_cr0 function as it is in Linux
Kernel. Seems that if this is missing, GCC is too smart and messes the order
of reads/writes to CR0 (not tested if really a problem here, but be safe for
future users of this function ;)

Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Maybe we can add nice copyright header too?

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvwIWoACgkQ3J9wPJqZRNV7/QCcD+WycESr5QIRGThVOX0UJmjL
I0wAn39m4vC0SdvZdFLoI23cxPMyEQb1
=qavi
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make_disable_a_c.patch
Type: text/x-diff
Size: 3072 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100516/9e51e49d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make_disable_a_c.patch.sig
Type: application/octet-stream
Size: 72 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100516/9e51e49d/attachment.obj>


More information about the coreboot mailing list