[coreboot] Fam10 error

Myles Watson mylesgw at gmail.com
Fri May 21 17:41:36 CEST 2010


coreboot-builds/amd_mahogany_fam10/make.log:src/cpu/amd/model_10xxx/fidvid.c:758:
warning: 'fid_max' may be used uninitialized in this function

static void init_fidvid_ap(u32 bsp_apicid, u32 apicid, u32 nodeid, u32 coreid)
...
	u32 fid_max;
...
		/* fid setup is handled by the BSP at the end. */

	} else {	/* ! nb_cof_vid_update */
		/* Use max values */
		if (pvimode)
			UpdateSinglePlaneNbVid();
	}

	send = (nb_cof_vid_update << 16) | (fid_max << 8);
	send |= (apicid << 24);	// ap apicid

	// Send signal to BSP about this AP max fid
	// This also indicates this AP is ready for warm reset (if required).
	lapic_write(LAPIC_MSG_REG, send | 1);

So we send garbage to the BSP for fid_max of the AP.  What should we
be sending instead if !nb_cof_vid_update?

Thanks,
Myles




More information about the coreboot mailing list