[coreboot] [PATCH] Improve i82830 MBI SMI Handler

[Joseph Smith]

On 05/21/2010 12:27 PM, Peter Stuge wrote:
> Joseph Smith wrote:
>> This patch improves the i82830 MBI SMI Handler. It is now able to load
>> Intel vbios VBT and Flexaim modules. Build and boot tested.
>>
>> Signed-off-by: Joseph Smith<joe at settoplinux.org>
>
> One issue, but other than that it is
>
> Acked-by: Peter Stuge<peter at stuge.se>
>
>
>> +++ src/northbridge/intel/i82830/i82830_smihandler.c	(working copy)
>> @@ -32,7 +32,7 @@
>>   extern unsigned char *mbi;
>>   extern u32 mbi_len;
>>
>> -// #define DEBUG_SMI_I82830
>> +#define DEBUG_SMI_I82830
>
> Really enable debugging here by default? Should this maybe come from
> Kconfig somehow. It could e.g. depend on some existing value in
> Kconfig.
>
 >
Oops, thanks for the catch. I was actually going to use Kconfig to 
enable it in the next patch.

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org