[coreboot] Patch for Nokia-IP530, now with working PIRQ table, fix on the pirq_routing

mbertens mbertens at xs4all.nl
Thu May 27 12:14:37 CEST 2010


Signed-off-by: Marc Bertens <mbertens at xs4all.nl>

Part two now the PIRQ table for the Nokia IP530.

Changes made:
- rebuild the table to get th eNICs and PCMCIA controllers get there
correct IRQs assigned. 
- Added a stub pirq_assign_irqs() due to the fact that it was missing at
compilation time. This was discussed with Rudolf Marek (ruik)
<r.marek at assembler.cz>

Marc


On Thu, 2010-05-27 at 11:56 +0200, mbertens wrote:

> Hi all,
> 
> Here is the patch just for the pirq_routing() function. Its made
> specific to the CONFIG_NORTHBRIDGE_INTEL_440BX if that is to generic 
> please replace by CONFIG_BOARD_NOKIA_IP530. 
> 
> Put the following extras in the file; 
> - added header accordingly "Common License Header" that was missing.
> - corrected a printk() warning of the compiler.
> - added the correction for the i440BX by AND the link value with 0x5F
>  so that always the value is kept below 0x5F. That AND value should be
>  0x03 i think because the link value cannot be greater than 3. But i'm
>  not sure about that, thats why i used the current solution.
> 
> The other patches will follow to day.
> 
> Marc 
> 
> 
> 
> On Wed, 2010-05-26 at 15:14 -0600, Myles Watson wrote:
> > On Wed, May 26, 2010 at 2:15 PM, mbertens <mbertens at xs4all.nl> wrote:
> > > On Wed, 2010-05-26 at 11:00 -0600, Myles Watson wrote:
> > >> +                     // fix made by Marc Bertens <mbertens at xs4all.nl>
> > >> +                     if (link > 0x5f) {
> > >> +                             // This is basically for the 440BX
> > >> +                             link -= 0x5f;
> > >> +                     }
> > >>
> > >> I'd prefer this to be guarded by
> > >> #if CONFIG_NORTHBRIDGE_INTEL_440BX (or whatever the correct one is)
> > > I was thinking of it to put it that way, but i'd. But i will make the
> > > changes to the code.
> > >>
> 





More information about the coreboot mailing list