[coreboot] [PATCH]: Entry key of fintek superio is 8787 instead of 87

[Bao, Zheng]

According to the description in datasheet of f71889,

"To enable configuration, the entry key 0x87 must be written to
the index port"

"
 -o 4e 87
 -o 4e 87	(enable configuration)
 -o 4e aa	(disable configuration)
"
This piece of text appears in most of the datasheet of fintek superio.
It doesnt say it quite clear, but it seems that the 0x87 should
be written twice. I tried on f81865, which is not in the coreboot tree
yet. If the 0x87 is only written once, you can only R/W the index/data
port once. All the subsequent RW will fail. Writing twice will be ok.

Plus, in the superiotool, the function
enter_conf_mode_winbond_fintek_ite_8787
also write 8787.

The fintek superio chips seem to enable the UART automatically when the
power is on. So I didnt find it failed to access.

Signed-off-by: Zheng Bao <zheng.bao at amd.com>


Index: src/superio/fintek/f71805f/f71805f_early_serial.c
===================================================================
--- src/superio/fintek/f71805f/f71805f_early_serial.c	(revision 6024)
+++ src/superio/fintek/f71805f/f71805f_early_serial.c	(working copy)
@@ -27,6 +27,7 @@
 {
 	u16 port = dev >> 8;
 	outb(0x87, port);
+	outb(0x87, port);
 }
 
 static void pnp_exit_conf_state(device_t dev)
Index: src/superio/fintek/f71859/f71859_early_serial.c
===================================================================
--- src/superio/fintek/f71859/f71859_early_serial.c	(revision 6024)
+++ src/superio/fintek/f71859/f71859_early_serial.c	(working copy)
@@ -27,6 +27,7 @@
 {
 	u16 port = dev >> 8;
 	outb(0x87, port);
+	outb(0x87, port);
 }
 
 static void pnp_exit_conf_state(device_t dev)
Index: src/superio/fintek/f71889/f71889_early_serial.c
===================================================================
--- src/superio/fintek/f71889/f71889_early_serial.c	(revision 6024)
+++ src/superio/fintek/f71889/f71889_early_serial.c	(working copy)
@@ -26,6 +26,7 @@
 {
 	u16 port = dev >> 8;
 	outb(0x87, port);
+	outb(0x87, port);
 }
 
 static void pnp_exit_conf_state(device_t dev)
Index: src/superio/fintek/f71863fg/f71863fg_early_serial.c
===================================================================
--- src/superio/fintek/f71863fg/f71863fg_early_serial.c	(revision 6024)
+++ src/superio/fintek/f71863fg/f71863fg_early_serial.c	(working copy)
@@ -27,6 +27,7 @@
 {
 	u16 port = dev >> 8;
 	outb(0x87, port);
+	outb(0x87, port);
 }
 
 static void pnp_exit_conf_state(device_t dev)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: superio_fintek_pnp_8787.patch
Type: application/octet-stream
Size: 2425 bytes
Desc: superio_fintek_pnp_8787.patch
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20101105/394326ff/attachment.obj>