[coreboot] [PATCH] fix S3 support on AMD K8 famF
stefan.reinauer at coresystems.de
Mon Nov 22 09:05:21 CET 2010
On 11/21/10 3:39 PM, Rudolf Marek wrote:
> 2) the patch implements get_cbmem_toc in chipset specific way if defined.
> On Intel targets it should be unchanged. On K8T890 the the cbmem_toc
> is read from NVRAM. Why you ask? Because we cannot do it as on intel,
> because the framebuffer might be there making it hard to look for it
> in memory (and remember we need it so early that everying is uncached)
Can't we read the size of the framebuffer on resume? Maybe the register
is connected to the resume power well?
> 3) The patch removes hardcoded limits for suspend/resume save area (it
> was 1MB) on intel. Now it computes right numbers itself.
This is good. We should look into reducing this size on most platforms
though. I think some AMD boards use incredibly high numbers for RAM_TOP
> I think I did not change the Intel suspend/resume behaviour but best
> would be if someone can test it.
Unfortunately I can not, at the moment. Hopefully someone can step in?
> Please note this patch was unfinished on my drive since ages and it
> would be very nice to get it in to prevent bit rotten it again.
> Now I feel it is done good way and should not break anything. I did a
> test with abuild and it seems fine.
> The Rachmann did suspend/resume support for Asus M2V he will post the
> patch soon.
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
Awesome! Thanks a lot for cleaning up behind me ;)
Acked-by: Stefan Reinauer <stepan at coreboot.org>
More information about the coreboot