[coreboot] [superiotool] patch for fintek f71889fg
uwe at hermann-uwe.de
Mon Nov 29 13:02:09 CET 2010
On Thu, Nov 04, 2010 at 12:46:16PM -0700, David Hendricks wrote:
> I am not certain what the difference is between the two chips, if any
> are discernible from superiotool's perspective. The F71889FG datasheet seems
> to be the public one -- the 0x23 and 0x07 chip IDs match the documented
> values. However, the chip I tested with has F71889ED printed on it and has
> 0x09 for the two chip ID bytes.
> I took a glance at the patch again and agree that there are several places
> where the code does not match the doc. Probably sloppy copy + paste on my
> part. Let's hold off on this patch until NTU, myself, or someone has time to
> check the accuracy.
I fixed up all issues I could see and committed a merged version from
your patch and the one from NTU (kept both Signed-off-by's) in r6131.
If you have a board with the 0909 ID you can test on, feel free to post
a patch which adds at least detection support for that chip. Until we
have a datasheet to check the registers I'd rather not add any guessed
register values to superiotool, though.
NTU, can you please post a "superiotool -d" output (use the latest
superiotool from trunk) from your board?
http://hermann-uwe.de | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org
More information about the coreboot