[coreboot] [PATCH try 2] Reduce duplicate definition in CAR code.

Warren Turkal wt at penguintechs.org
Thu Oct 7 09:12:57 CEST 2010


On Wed, Oct 6, 2010 at 12:34 PM, Stefan Reinauer
<stefan.reinauer at coresystems.de> wrote:
>  On 10/6/10 10:23 AM, Uwe Hermann wrote:
>> They're only used once per cache_as_ram.inc file, but every such file
>> has that list, so putting the list in an mtrr_defs.inc or the like
>> and using ".include mtrr_defs.inc" in every cache_as_ram.inc would
>> be nice IMHO.
> They're not necessarily the same on all platforms though I think.

The common ones appear to be the same. In fact, they appear to have
been copy/pasted. AMD had some that were AMD specific, so those got
their own macro.

Thanks,
wt




More information about the coreboot mailing list