[coreboot] [patch] fix Windows 7 checked build assert caused by FADT length/revision inconsistency

Peter Stuge peter at stuge.se
Sun Oct 24 05:51:27 CEST 2010


Scott Duplichan wrote:
> Running a checked build of Windows is needed for understanding
> its various BIOS related BSODs. Win7 checked build complains
> when running coreboot+seabios:
> 
> FADT revision inconsistent with length.
>     Revision:        0x1
>     Length:          0xf4
>     Expected Length: 0x74
> 
> The following patch solves the problem. Tested on Mahogany_fam10 only.
> 
> 
> Signed-off-by: Scott Duplichan <scott at notabs.org>

Acked-by: Peter Stuge <peter at stuge.se>


> +++ src/southbridge/nvidia/ck804/ck804_fadt.c	(working copy)
> +++ src/mainboard/iwill/dk8_htx/fadt.c	(working copy)
> +++ src/mainboard/asrock/939a785gmh/fadt.c	(working copy)
> +++ src/mainboard/kontron/kt690/fadt.c	(working copy)
> +++ src/mainboard/gigabyte/ma78gm/fadt.c	(working copy)
> +++ src/mainboard/gigabyte/ma785gmt/fadt.c	(working copy)
> +++ src/mainboard/amd/mahogany/fadt.c	(working copy)
> +++ src/mainboard/amd/pistachio/fadt.c	(working copy)
> +++ src/mainboard/amd/dbm690t/fadt.c	(working copy)
> +++ src/mainboard/amd/serengeti_cheetah/fadt.c	(working copy)
> +++ src/mainboard/amd/mahogany_fam10/fadt.c	(working copy)
> +++ src/mainboard/amd/tilapia_fam10/fadt.c	(working copy)
> +++ src/mainboard/amd/serengeti_cheetah_fam10/fadt.c	(working copy)
> +++ src/mainboard/iei/kino-780am2-fam10/fadt.c	(working copy)
> +++ src/mainboard/via/epia-m700/fadt.c	(working copy)
> +++ src/mainboard/via/vt8454c/fadt.c	(working copy)
> +++ src/mainboard/via/epia-m/fadt.c	(working copy)
> +++ src/mainboard/via/epia-n/fadt.c	(working copy)
> +++ src/mainboard/jetway/pa78vm5/fadt.c	(working copy)
> +++ src/mainboard/technexion/tim8690/fadt.c	(working copy)
> +++ src/mainboard/technexion/tim5690/fadt.c	(working copy)
> +++ src/mainboard/intel/eagleheights/fadt.c	(working copy)
> +++ src/mainboard/asus/m4a785-m/fadt.c	(working copy)
> +++ src/southbridge/nvidia/ck804/ck804_fadt.c	(working copy)
> +++ src/mainboard/iwill/dk8_htx/fadt.c	(working copy)
> +++ src/mainboard/asrock/939a785gmh/fadt.c	(working copy)
> +++ src/mainboard/kontron/kt690/fadt.c	(working copy)
> +++ src/mainboard/gigabyte/ma78gm/fadt.c	(working copy)
> +++ src/mainboard/gigabyte/ma785gmt/fadt.c	(working copy)
> +++ src/mainboard/amd/mahogany/fadt.c	(working copy)
> +++ src/mainboard/amd/pistachio/fadt.c	(working copy)
> +++ src/mainboard/amd/dbm690t/fadt.c	(working copy)
> +++ src/mainboard/amd/serengeti_cheetah/fadt.c	(working copy)
> +++ src/mainboard/amd/mahogany_fam10/fadt.c	(working copy)
> +++ src/mainboard/amd/tilapia_fam10/fadt.c	(working copy)
> +++ src/mainboard/amd/serengeti_cheetah_fam10/fadt.c	(working copy)
> +++ src/mainboard/iei/kino-780am2-fam10/fadt.c	(working copy)
> +++ src/mainboard/via/epia-m700/fadt.c	(working copy)
> +++ src/mainboard/via/vt8454c/fadt.c	(working copy)
> +++ src/mainboard/via/epia-m/fadt.c	(working copy)
> +++ src/mainboard/via/epia-n/fadt.c	(working copy)
> +++ src/mainboard/jetway/pa78vm5/fadt.c	(working copy)
> +++ src/mainboard/technexion/tim8690/fadt.c	(working copy)
> +++ src/mainboard/technexion/tim5690/fadt.c	(working copy)
> +++ src/mainboard/intel/eagleheights/fadt.c	(working copy)
> +++ src/mainboard/asus/m4a785-m/fadt.c	(working copy)

It would be very nice to refactor all these files.


//Peter




More information about the coreboot mailing list