[coreboot] Stop #include of source files

Marc Jones marcj303 at gmail.com
Mon Sep 27 23:58:22 CEST 2010


On Sat, Sep 25, 2010 at 1:30 PM, Peter Stuge <peter at stuge.se> wrote:
> Patrick Georgi wrote:
>> > Alternatively, we could collect object lists for gcc based builds and
>> > for romcc based builds we create a list of source files and include them
>> > in an autogenerated file. Same effect, but much more readable. i.e.
>> Brilliant plan!
>
> +1
>

+1 me too!

>> It requires a switch over for the *obj* variables to source files -
>> should we do that for all of them as a first step?
>
> Hm aren't the obj lists still needed for the link?
>
>
>> Also, what should we call them? This is a brilliant opportunity to
>> rename them - we have:
>> initobj       (rename to romstage-src?)
>> obj   (rename to ramstage-src?)
>> driver        (rename to driver-src?)
>> smmobj        (rename to smm-src?)
>
> I like the suggested names. Big improvement!

I think so too!

Marc



-- 
http://se-eng.com




More information about the coreboot mailing list