[coreboot] [commit] r6523 - in trunk/src: include lib southbridge/via/vt82c686

repository service svn at coreboot.org
Wed Apr 20 03:08:27 CEST 2011


Author: stepan
Date: Wed Apr 20 03:08:25 2011
New Revision: 6523
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6523

Log:
drop dead uart init code.
Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Modified:
   trunk/src/include/uart8250.h
   trunk/src/lib/uart8250.c
   trunk/src/southbridge/via/vt82c686/chip.h

Modified: trunk/src/include/uart8250.h
==============================================================================
--- trunk/src/include/uart8250.h	Wed Apr 20 03:03:58 2011	(r6522)
+++ trunk/src/include/uart8250.h	Wed Apr 20 03:08:25 2011	(r6523)
@@ -131,11 +131,6 @@
 
 
 #ifndef __ROMCC__
-// Can't we just drop this? It seems silly.
-struct uart8250 {
-	unsigned int baud;
-};
-
 unsigned char uart8250_rx_byte(unsigned base_port);
 int uart8250_can_rx_byte(unsigned base_port);
 void uart8250_tx_byte(unsigned base_port, unsigned char data);
@@ -144,7 +139,6 @@
  * have three different sets of uart code, so it's an improvement.
  */
 void uart8250_init(unsigned base_port, unsigned divisor);
-void init_uart8250(unsigned base_port, struct uart8250 *uart);
 void uart_init(void);
 #endif
 

Modified: trunk/src/lib/uart8250.c
==============================================================================
--- trunk/src/lib/uart8250.c	Wed Apr 20 03:03:58 2011	(r6522)
+++ trunk/src/lib/uart8250.c	Wed Apr 20 03:08:25 2011	(r6523)
@@ -86,23 +86,6 @@
 	outb(CONFIG_TTYS0_LCS, base_port + UART_LCR);
 }
 
-#ifndef __ROMCC__
-/* Initialize a generic uart */
-void init_uart8250(unsigned base_port, struct uart8250 *uart)
-{
-	int divisor = uart->baud ? (115200/uart->baud) : 1;
-
-	if (base_port == CONFIG_TTYS0_BASE) {
-		/* Don't reinitialize the console serial port,
-		 * This is espeically nasty in SMP.
-		 * NOTE: The first invocation thus always needs to be 
-		 */
-		return;
-	}
-	uart8250_init(base_port, divisor);
-}
-#endif
-
 #if defined(__PRE_RAM__) || defined(__SMM__)
 void uart_init(void)
 {

Modified: trunk/src/southbridge/via/vt82c686/chip.h
==============================================================================
--- trunk/src/southbridge/via/vt82c686/chip.h	Wed Apr 20 03:03:58 2011	(r6522)
+++ trunk/src/southbridge/via/vt82c686/chip.h	Wed Apr 20 03:08:25 2011	(r6523)
@@ -28,7 +28,6 @@
 extern struct chip_operations superio_via_vt82c686_ops;
 
 struct superio_via_vt82c686_config {
-	struct uart8250 com1, com2;
 	struct pc_keyboard keyboard;
 };
 




More information about the coreboot mailing list