[coreboot] [PATCH 1/4] pci1x2x: use devicetree register configuration
Stefan Reinauer
stefan.reinauer at coreboot.org
Wed Apr 20 03:32:56 CEST 2011
* Sven Schnelle <svens at stackframe.org> [110419 21:47]:
> Signed-off-by: Sven Schnelle <svens at stackframe.org>
> static void ti_pci1x2y_init(struct device *dev)
> {
> +
> printk(BIOS_INFO, "Init of Texas Instruments PCI1x2x PCMCIA/CardBus controller\n");
> + struct southbridge_ti_pci1x2x_config *conf = dev->chip_info;
You should check if dev or conf is actually set before accessing it.
I believe if the device is not mentioned in devicetree.cb conf will be
NULL.
See some i82801gx drivers for an example.
Other than that:
Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
More information about the coreboot
mailing list