[coreboot] New patch to review: 4e4140f Remove debugging code, or convert it to be selected by kconfig

Jonathan A. Kollasch (jakllsch@kollasch.net) gerrit at coreboot.org
Wed Aug 3 20:57:27 CEST 2011


Jonathan A. Kollasch (jakllsch at kollasch.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/130

-gerrit

commit 4e4140fb91b21116877205b6ce5370803eda8d83
Author: Jonathan A. Kollasch <jakllsch at kollasch.net>
Date:   Wed Aug 3 13:56:24 2011 -0500

    Remove debugging code, or convert it to be selected by kconfig
    
    Change-Id: Ib6cd82badeb6401e065ee14c2a04c78f61a87dd4
    Signed-off-by: Jonathan A. Kollasch <jakllsch at kollasch.net>
---
 src/mainboard/msi/ms7135/romstage.c |   11 +----------
 1 files changed, 1 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/msi/ms7135/romstage.c b/src/mainboard/msi/ms7135/romstage.c
index 5feef79..80b3c19 100644
--- a/src/mainboard/msi/ms7135/romstage.c
+++ b/src/mainboard/msi/ms7135/romstage.c
@@ -112,10 +112,6 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 	/* Halt if there was a built in self test failure */
 	report_bist_failure(bist);
 
-#if 0
-	dump_pci_device(PCI_DEV(0, 0x18, 0));
-#endif
-
 	needs_reset = setup_coherent_ht_domain();
 
 	wait_all_core0_started();
@@ -140,17 +136,12 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 
 	enable_smbus();
 
-#if 0
+#if CONFIG_DEBUG_SMBUS
 	dump_spd_registers(&ctrl[0]);
 	dump_smbus_registers();
 #endif
 
 	sdram_initialize(nodes, ctrl);
 
-#if 0
-	print_pci_devices();
-	dump_pci_devices();
-#endif
-
 	post_cache_as_ram();
 }




More information about the coreboot mailing list