[coreboot] New patch to review: 000ea38 AMD F14 Rev C0 update

Paul Menzel paulepanter at users.sourceforge.net
Thu Aug 18 12:44:43 CEST 2011


Dear Kerry,


Am Donnerstag, den 18.08.2011, 12:33 +0200 schrieb Kerry She:
> Kerry She (shekairui at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/160
> 
> -gerrit
> 
> commit 000ea3878c8d28dc79897c997f5ca82366542da8
> Author: Kerry She <shekairui at gmail.com>
> Date:   Thu Aug 18 18:58:40 2011 +0800
> 
>     AMD F14 Rev C0 update
>     
>     Add AMD Family14 Rev C0 cpu id

The second line is in my opinion even a better commit summary.

Could you also add if this was tested or did you just add the ID?

>     Change-Id: Iacd1c7b20e889da61a2085188766285f27e5c018
>     Signed-off-by: Kerry She <kerry.she at amd.com>
>     Signed-off-by: Kerry She <shekairui at gmail.com>

With the comments addressed this patch is

Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>

and I am sorry not having an OpenID account to use Gerrit yet.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20110818/82af4ba4/attachment.sig>


More information about the coreboot mailing list