[coreboot] New patch to review: 782eae6 BUILD: add .config dependency to $(obj)/config.h

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Mon Aug 22 10:40:12 CEST 2011


Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/169

-gerrit

commit 782eae6fc75f75046bd89c0b4bb72b269ce13992
Author: Sven Schnelle <svens at stackframe.org>
Date:   Mon Aug 22 10:38:11 2011 +0200

    BUILD: add .config dependency to $(obj)/config.h
    
    Without it, replacing .config by a different config leads to all
    kinds of annoying build errors like the following:
    $ cp config-t60p .config
    $ make
    Makefile:235: warning: overriding commands for target `build/cpu/x86/name/name.ramstage.o'
    Makefile:235: warning: ignoring old commands for target `build/cpu/x86/name/name.ramstage.o'
        ROMCC      mainboard/lenovo/t60/bootblock.inc
        GEN        bootblock/bootblock.S
        CC         mainboard/lenovo/t60/bootblock.s
        CC         mainboard/lenovo/t60/bootblock.o
        LINK       bootblock.elf
        OBJCOPY    coreboot.bootblock
        CC         lib/ramtest.romstage.o
    cc1: warnings being treated as errors
    src/lib/ramtest.c: In function 'ram_fill':
    src/lib/ramtest.c:60:2: error: format '%08x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
    src/lib/ramtest.c:60:2: error: format '%08x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
    src/lib/ramtest.c:62:2: error: format '%08x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
    src/lib/ramtest.c:62:2: error: format '%08x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
    src/lib/ramtest.c:71:4: error: format '%08x' expects type 'unsigned int', but argument 3 has type 'long unsigned int'
    [..]
    
    Change-Id: I0d0509980009f062f621d2afec200f2c5ab0cafa
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 44a1d63..1fd084f 100644
--- a/Makefile
+++ b/Makefile
@@ -158,7 +158,7 @@ endif
 # must come rather early
 .SECONDEXPANSION:
 
-$(obj)/config.h:
+$(obj)/config.h: .config
 	$(MAKE) oldconfig
 
 # Add a new class of source/object files to the build system




More information about the coreboot mailing list