[coreboot] New patch to review for coreboot: 98cd3c8 Fix missing cast back to void *

Philip Prindeville (pprindeville@gmail.com) gerrit at coreboot.org
Sat Dec 24 01:54:17 CET 2011


Philip Prindeville (pprindeville at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/500

-gerrit

commit 98cd3c8d5b16d4369e25ddca6a313d59f2a0bf4a
Author: Philip Prindeville <philipp at redfish-solutions.com>
Date:   Fri Dec 23 17:53:26 2011 -0700

    Fix missing cast back to void *
    
    MEM_RANGE_PTR() also needs to return a pointer to untyped memory.
    
    Change-Id: I0ec64ad7bdb136d5e1a999bff3df6fa66eb29bf1
    Signed-off-by: Philip Prindeville <philipp at redfish-solutions.com>
---
 payloads/libpayload/include/coreboot_tables.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h
index 574469a..e362d06 100644
--- a/payloads/libpayload/include/coreboot_tables.h
+++ b/payloads/libpayload/include/coreboot_tables.h
@@ -234,8 +234,8 @@ static inline u16 cb_checksum(const void *ptr, unsigned len)
 	(((_rec)->size - sizeof(*(_rec))) / sizeof((_rec)->map[0]))
 
 #define MEM_RANGE_PTR(_rec, _idx) \
-	(((u8 *) (_rec)) + sizeof(*(_rec)) \
-	+ (sizeof((_rec)->map[0]) * (_idx)))
+	(void *)(((u8 *) (_rec)) + sizeof(*(_rec)) \
+		+ (sizeof((_rec)->map[0]) * (_idx)))
 
 #define MB_VENDOR_STRING(_mb) \
 	(((unsigned char *) ((_mb)->strings)) + (_mb)->vendor_idx)




More information about the coreboot mailing list