[coreboot] [PATCH] Proposal for dealing with superio *.c includes

Alex G. mr.nuke.me at gmail.com
Sat Feb 26 22:27:47 CET 2011


On 02/26/2011 10:50 PM, Patrick Georgi wrote:
> Am Samstag, 26. Februar 2011, 14:17:37 schrieb Alex G.:
>> 3) add a romstage-$(CONFIG_THIS_SUPERIO) += early_serial.c to the
>> superio's Makefile.inc
> This will fail for romcc boards, as for them, romstage must be compiled by a 
> single romcc invocation.
> 
If we break romcc boards in an effort to efficientize the code base, I
am all for it, just so as long as we plead to fix it not much later down
the road.

> I planned to work on this by having the build system generate a wrapper for 
> romcc boards automatically  (essentially a file in $(obj) with romstage.c and 
> other .c files #included, properly hidden from the dev), but that has some 
> issues with the right order in which things must be included (romcc doesn't 
> support forward declarations).
> 
Why bother holding dear to romcc when the obvious solution is to move
those boards to CAR? We introduce more unneeded complexity, and make it
at least just as hard to phase out romcc.

Alex




More information about the coreboot mailing list