[coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

Stefan Reinauer stepan at coreboot.org
Mon Jan 17 04:48:38 CET 2011


* Peter Stuge <peter at stuge.se> [110117 02:32]:
> Kevin O'Connor wrote:
> > The cn700.c code references mainboard_interrupt_handlers() which isn't
> > defined if VGA_ROM_RUN is off.  Define a dummy implementation of that
> > function for this case.
> 
> Shouldn't cn700.c code be changed instead, so that it doesn't
> reference the function when VGA_ROM_RUN is off?

Possibly. In this case it would require an ifdef in each of these files:
./src/mainboard/technexion/tim5690/vgabios.c
./src/northbridge/via/cn400/vga.c
./src/northbridge/via/cn700/vga.c
./src/northbridge/via/cx700/vga.c
./src/northbridge/via/vt8623/vga.c
./src/northbridge/via/vx800/vga.c
because they all expose the same problem.

instead of the one in ./src/arch/x86/include/arch/interrupt.h

Stefan





More information about the coreboot mailing list