[coreboot] [commit] r5902 - in trunk/src: cpu/amd/car cpu/intel/car cpu/intel/model_106cx cpu/intel/model_6ex cpu/intel/model_6fx cpu/via/car include/cpu/x86

Kevin O'Connor kevin at koconnor.net
Mon Jan 17 16:17:28 CET 2011


On Sun, Jan 16, 2011 at 10:38:54PM +0100, Stefan Reinauer wrote:
> * Kevin O'Connor <kevin at koconnor.net> [110116 20:04]:
> > On Fri, Oct 01, 2010 at 11:46:05PM +0200, repository service wrote:
> > > Author: uwe
> > > Date: Fri Oct  1 23:46:04 2010
> > > New Revision: 5902
> > > URL: https://tracker.coreboot.org/trac/coreboot/changeset/5902
> > > 
> > > Log:
> > > Factor out common CAR asm snippets.
> > > 
> > > This makes the CAR implementations a lot more readable, shorter and
> > > easier to follow, and also reduces the amount of uselessly duplicated code.
> > > 
> > > For example there are more than 12 open-coded "enable cache" instances
> > > spread all over the place (and 12 "disable cache" ones), multiple
> > > "enable mtrr", "save BIST", "restore BIST", etc. etc.
> > > 
> > > Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> > > Acked-by: Peter Stuge <peter at stuge.se>
> > 
> > I'd like to express my disapointment that this patch went in.  Today I
> > updated my repo and went to find out why my epia-cn reverted (yet
> > again) to doing lzma uncompression without caching.  I had to wade
> > through the effects of this patch.  This patch is a regression - it
> > makes the code harder to understand.
> > 
> > -Kevin
> 
> I agree. And I would like to back it out. Will do so if I get 2 acks.
> 
> Signed-off-by: Stefan Reinauer <stepan at coreboot.org>

Acked-by: Kevin O'Connor <kevin at koconnor.net>

-Kevin




More information about the coreboot mailing list