[coreboot] New patch to review: 88f214e X60: remove pci config register save/restore
Sven Schnelle (svens@stackframe.org)
gerrit at coreboot.org
Tue Jun 28 08:50:43 CEST 2011
Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at
http://review.coreboot.org/65
-gerrit
commit 88f214ec674aa77c05742b31553b671e566ce01a
Author: Sven Schnelle <svens at stackframe.org>
Date: Tue Jun 28 08:05:26 2011 +0200
X60: remove pci config register save/restore
SMM code already makes sure this register is saved and restored,
so we don't have to do it.
Change-Id: I078e1227de4436fba9c5fb3879a564c981cb0f9a
Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
src/mainboard/lenovo/x60/mainboard_smi.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/mainboard/lenovo/x60/mainboard_smi.c b/src/mainboard/lenovo/x60/mainboard_smi.c
index fd10c9a..a0df76a 100644
--- a/src/mainboard/lenovo/x60/mainboard_smi.c
+++ b/src/mainboard/lenovo/x60/mainboard_smi.c
@@ -46,11 +46,10 @@ static void mainboard_smm_init(void)
static void mainboard_smi_save_cmos(void)
{
u8 val;
- u8 tmp70, tmp72, tmpcf8;
+ u8 tmp70, tmp72;
tmp70 = inb(0x70);
tmp72 = inb(0x72);
- tmpcf8 = inl(0xcf8);
val = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4);
set_option("tft_brightness", &val);
@@ -59,7 +58,6 @@ static void mainboard_smi_save_cmos(void)
outb(tmp70, 0x70);
outb(tmp72, 0x72);
- outb(tmpcf8, 0xcf8);
}
int mainboard_io_trap_handler(int smif)
More information about the coreboot
mailing list