[coreboot] New patch to review: f65442a We use LDTSTOP# to trigger the FID/VID change on K8M890, because the FID/VID SMAF is blocked by not yet configured internal VGA. Workaround the errata #181. The memory controller is enabled later, nor the workaround makes any harm to non-affected CPUs.

[Rudolf Marek (r.marek@assembler.cz)]

Rudolf Marek (r.marek at assembler.cz) just uploaded a new patch set to gerrit, which you can find at
http://review.coreboot.org/69

-gerrit

commit f65442a479a1ace2badd1dcf2a5efd3e13dd226d
Author: Rudolf Marek <r.marek at assembler.cz>
Date:   Wed Jun 29 23:59:13 2011 +0200

    We use LDTSTOP# to trigger the FID/VID change on K8M890, because the FID/VID SMAF
    is blocked by not yet configured internal VGA. Workaround the errata #181.
    The memory controller is enabled later, nor the workaround makes any harm
    to non-affected CPUs.
    
    Change-Id: Icf5d126b8c8cd9ece6af41d3129315a777c8cef2
    Signed-off-by: Rudolf Marek <r.marek at assembler.cz>
---
 src/mainboard/asus/m2v-mx_se/romstage.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/src/mainboard/asus/m2v-mx_se/romstage.c b/src/mainboard/asus/m2v-mx_se/romstage.c
index 580d8fa..6498e46 100644
--- a/src/mainboard/asus/m2v-mx_se/romstage.c
+++ b/src/mainboard/asus/m2v-mx_se/romstage.c
@@ -74,10 +74,15 @@ static inline int spd_read_byte(unsigned device, unsigned address)
 
 #define SB_VFSMAF 0
 
-/* this function might fail on some K8 CPUs with errata #181 */
 static void ldtstop_sb(void)
 {
 	print_debug("toggle LDTSTP#\n");
+
+	/* fix errata #181, disable DRAM controller it will get enabled later */
+	tmp = pci_read_config8(PCI_DEV(0, 0x18, 2), 0x94);
+	tmp |= (( 1 << 14) | (1 << 3));
+	pci_write_config8(PCI_DEV(0, 0x18, 2), 0x94, tmp);
+
 	u8 reg = inb (VT8237R_ACPI_IO_BASE + 0x5c);
 	reg = reg ^ (1 << 0);
 	outb(reg, VT8237R_ACPI_IO_BASE + 0x5c);