[coreboot] [commit] r6451 - trunk/src/southbridge/amd/sb600

repository service svn at coreboot.org
Thu Mar 17 13:34:16 CET 2011


Author: oxygene
Date: Thu Mar 17 13:34:15 2011
New Revision: 6451
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6451

Log:
Fix power_on_after_fail handling on AMD SB600

Bit 0 of pm reg#74 have to be set turn on system after power resumes.
See '42661_sb600_rrg_nda_3.02.pdf' (or '46155_sb600_rrg_pub_3.03.pdf')
for details, look for 'PwrFailShadow'.

[Patrick: I didn't include the get_options reorganization as get_option
doesn't overwrite "on" if power_on_after_fail isn't found in CMOS.
Style changes were also left out.]

Signed-off-by: Josef Kellermann <seppk at arcor.de>
Acked-by: Patrick Georgi <patrick.georgi at secunet.com>

Modified:
   trunk/src/southbridge/amd/sb600/sm.c

Modified: trunk/src/southbridge/amd/sb600/sm.c
==============================================================================
--- trunk/src/southbridge/amd/sb600/sm.c	Thu Mar 17 13:20:04 2011	(r6450)
+++ trunk/src/southbridge/amd/sb600/sm.c	Thu Mar 17 13:34:15 2011	(r6451)
@@ -94,7 +94,7 @@
 	byte = pm_ioread(0x74);
 	byte &= ~0x03;
 	if (on) {
-		byte |= 2;
+		byte |= 1 << 0;
 	}
 	byte |= 1 << 2;
 	pm_iowrite(0x74, byte);




More information about the coreboot mailing list