[coreboot] [PATCH] 440BX registered SDRAM support

Stefan Reinauer stefan.reinauer at coreboot.org
Tue Mar 29 23:34:51 CEST 2011


* Keith Hui <buurin at gmail.com> [110329 06:11]:
> >> +    if ((edosd & 0x84) == 0x84) {
> >> +        edosd = 0x10; // Registered SDRAM
> >> +    } else {
> >> +        // Clear [4:3] in case it's EDO.
> >> +        edosd &= 0x07;
> >> +//    } else if (edosd & 0x02) {
> > Besides being commented out, this piece of code would never be executed,
> > as there already is an else case.
> > Also, modifying edosd in place is semi nice.
> 
> So is this good, not so good, or bad?
> 
> I want to know if I should split up edosd.

Please do.





More information about the coreboot mailing list