[coreboot] [PATCH] ICH7: Fix register naming error
Stefan Reinauer
stefan.reinauer at coreboot.org
Thu Mar 31 23:25:08 CEST 2011
* Sven Schnelle <svens at stackframe.org> [110331 17:15]:
> There's an off-by-one error in the ACPI GP_LVL declaration:
> it declares GL00 with a bit count of 6, and continues with GP07
> afterwards. This should be GP06, as the first bitfield covers
> GP00-GP05.
>
> While at it, change it to GP00-GP05, as right now GL00 isn't used,
> and single bitfield are more usable here.
>
> Als adjust the Getac P470, as this is the only user of those defintions
> right now.
>
> Signed-off-by: Sven Schnelle <svens at stackframe.org>
> ---
> src/mainboard/getac/p470/acpi/ec.asl | 26 +++++++-------
> src/southbridge/intel/i82801gx/acpi/ich7.asl | 46 ++++++++++++++-----------
> 2 files changed, 39 insertions(+), 33 deletions(-)
Thanks for finding this.
Acked-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
More information about the coreboot
mailing list