[coreboot] Patch merged into coreboot/master: 51caef5 mptable: Refactor lintsrc generation

gerrit at coreboot.org gerrit at coreboot.org
Thu Oct 13 01:10:34 CEST 2011


the following patch was just integrated into master:
commit 51caef5bb69445b65f4d7e468abe06bdb95de7b9
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Fri Oct 7 21:42:52 2011 +0200

    mptable: Refactor lintsrc generation
    
    We copied pretty much the same code for generating mptable entries for
    local interrupts (with some notable exceptions).
    This change moves these lines into a generic function "mptable_lintsrc"
    and makes use of it in many places.
    
    The remaining uses of smp_write_lintsrc should be reviewed and replaced
    by mptable_lintsrc calls where possible, and smp_write_lintsrc made static.
    
    This patch was generated using Coccinelle:
      @@
      expression mc;
      expression isa_bus;
      @@
      -smp_write_lintsrc(mc, mp_ExtINT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, isa_bus, 0x0, MP_APIC_ALL, 0x0);
      -smp_write_lintsrc(mc, mp_NMI, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, isa_bus, 0x0, MP_APIC_ALL, 0x1);
      +mptable_lintsrc(mc, isa_bus);
    
      @@
      expression mc;
      expression isa_bus;
      @@
      -smp_write_lintsrc(mc, mp_ExtINT, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, isa_bus, 0x0, MP_APIC_ALL, 0x0);
      -smp_write_lintsrc(mc, mp_NMI, MP_IRQ_TRIGGER_EDGE|MP_IRQ_POLARITY_HIGH, isa_bus, 0x0, MP_APIC_ALL, 0x1);
      +mptable_lintsrc(mc, isa_bus);
    
      @m@
      identifier mc;
      expression BUS;
      @@
      -#define IO_LOCAL_INT(type, intr, apicid, pin) smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, BUS, (intr), (apicid), (pin));
      ...
      -IO_LOCAL_INT(mp_ExtINT, 0x0, MP_APIC_ALL, 0x0);
      -IO_LOCAL_INT(mp_NMI, 0x0, MP_APIC_ALL, 0x1);
      +mptable_lintsrc(mc, BUS);
    
    Change-Id: I97421f820cd039f5fd753cb0da5c1cca68819bb4
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>

See http://review.coreboot.org/244 for details.

-gerrit




More information about the coreboot mailing list