[coreboot] Patch set updated for coreboot: fcb4358 More portable s3 scratch space creation
Patrick Georgi (patrick@georgi-clan.de)
gerrit at coreboot.org
Thu Apr 12 15:27:39 CEST 2012
Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/889
-gerrit
commit fcb4358908704fa31adc3eb051692307fc2a89ce
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date: Thu Apr 12 15:03:22 2012 +0200
More portable s3 scratch space creation
echo -n isn't portable. echo -e isn't portable. that bash loop isn't portable.
So let's try something else.
Change-Id: Ie73aa1c09d90c11a5c4952a332d4c2058390b5db
Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
src/southbridge/amd/Makefile.inc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc
index 2cdca29..f4a9cbb 100644
--- a/src/southbridge/amd/Makefile.inc
+++ b/src/southbridge/amd/Makefile.inc
@@ -17,8 +17,8 @@ subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB900) += cimx
$(obj)/s3.rom:
echo " S3 NVRAM 0xffff0000 (S3 storage area)"
- echo -ne '\xFF' > $@
- for ((i=0;i<20479;i++)) do echo -ne '\xFF' >> $@ ; done
+ awk 'BEGIN {for (i=0; i<20480; i++) {printf "%c", 255}}' > $@.tmp
+ mv $@.tmp $@
ifeq ($(CONFIG_HAVE_ACPI_RESUME), y)
cbfs-files-y += s3nv
More information about the coreboot
mailing list