[coreboot] Patch set updated for coreboot: 6d2673d Fix messy code in ALIB creation
Zheng Bao (zheng.bao@amd.com)
gerrit at coreboot.org
Thu Apr 19 04:04:04 CEST 2012
Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/885
-gerrit
commit 6d2673d290b8f2c672e0e85f0c21e27bef8fd200
Author: zbao <fishbaozi at gmail.com>
Date: Fri Apr 13 13:48:50 2012 +0800
Fix messy code in ALIB creation
Fix the copy-paste typo in ALIB table creation. ssdt is useless here.
Change-Id: I250066eb5f755275f75c37789ce8760de35b046b
Signed-off-by: Zheng Bao <zheng.bao at amd.com>
Signed-off-by: zbao <fishbaozi at gmail.com>
---
src/mainboard/amd/dinar/acpi_tables.c | 4 ++--
src/mainboard/amd/inagua/acpi_tables.c | 7 +++----
src/mainboard/amd/persimmon/acpi_tables.c | 7 +++----
src/mainboard/amd/south_station/acpi_tables.c | 7 +++----
src/mainboard/amd/union_station/acpi_tables.c | 7 +++----
src/mainboard/asrock/e350m1/acpi_tables.c | 7 +++----
src/mainboard/supermicro/h8qgi/acpi_tables.c | 4 ++--
7 files changed, 19 insertions(+), 24 deletions(-)
diff --git a/src/mainboard/amd/dinar/acpi_tables.c b/src/mainboard/amd/dinar/acpi_tables.c
index 0ec66ce..db01d79 100644
--- a/src/mainboard/amd/dinar/acpi_tables.c
+++ b/src/mainboard/amd/dinar/acpi_tables.c
@@ -290,9 +290,9 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
+ acpi_add_table(rsdp, (void *)alib);
} else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/amd/inagua/acpi_tables.c b/src/mainboard/amd/inagua/acpi_tables.c
index ff3b7db..a4504d4 100644
--- a/src/mainboard/amd/inagua/acpi_tables.c
+++ b/src/mainboard/amd/inagua/acpi_tables.c
@@ -256,11 +256,10 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
- }
- else {
+ acpi_add_table(rsdp, (void *)alib);
+ } else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/amd/persimmon/acpi_tables.c b/src/mainboard/amd/persimmon/acpi_tables.c
index 4a44a5a..cb415fd 100644
--- a/src/mainboard/amd/persimmon/acpi_tables.c
+++ b/src/mainboard/amd/persimmon/acpi_tables.c
@@ -256,11 +256,10 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
- }
- else {
+ acpi_add_table(rsdp, (void *)alib);
+ } else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/amd/south_station/acpi_tables.c b/src/mainboard/amd/south_station/acpi_tables.c
index e32a42b..5c958a0 100644
--- a/src/mainboard/amd/south_station/acpi_tables.c
+++ b/src/mainboard/amd/south_station/acpi_tables.c
@@ -256,11 +256,10 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
- }
- else {
+ acpi_add_table(rsdp, (void *)alib);
+ } else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/amd/union_station/acpi_tables.c b/src/mainboard/amd/union_station/acpi_tables.c
index e32a42b..5c958a0 100644
--- a/src/mainboard/amd/union_station/acpi_tables.c
+++ b/src/mainboard/amd/union_station/acpi_tables.c
@@ -256,11 +256,10 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
- }
- else {
+ acpi_add_table(rsdp, (void *)alib);
+ } else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/asrock/e350m1/acpi_tables.c b/src/mainboard/asrock/e350m1/acpi_tables.c
index e32a42b..5c958a0 100644
--- a/src/mainboard/asrock/e350m1/acpi_tables.c
+++ b/src/mainboard/asrock/e350m1/acpi_tables.c
@@ -256,11 +256,10 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
- }
- else {
+ acpi_add_table(rsdp, (void *)alib);
+ } else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
diff --git a/src/mainboard/supermicro/h8qgi/acpi_tables.c b/src/mainboard/supermicro/h8qgi/acpi_tables.c
index 77c0772..f6db214 100644
--- a/src/mainboard/supermicro/h8qgi/acpi_tables.c
+++ b/src/mainboard/supermicro/h8qgi/acpi_tables.c
@@ -290,9 +290,9 @@ unsigned long write_acpi_tables(unsigned long start)
alib = (acpi_header_t *)agesawrapper_getlateinitptr (PICK_ALIB);
if (alib != NULL) {
memcpy((void *)current, alib, alib->length);
- ssdt = (acpi_header_t *) current;
+ alib = (acpi_header_t *) current;
current += alib->length;
- acpi_add_table(rsdp,alib);
+ acpi_add_table(rsdp, (void *)alib);
} else {
printk(BIOS_DEBUG, " AGESA ALIB SSDT table NULL. Skipping.\n");
}
More information about the coreboot
mailing list