[coreboot] Patch set updated for coreboot: 0aa8793 mptable: bring sanity back to mptable generation (TRIVIAL)
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Wed Aug 22 00:11:55 CEST 2012
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1474
-gerrit
commit 0aa87931c668aef4169f4b6575b15dd03d55e49c
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Tue Aug 21 17:08:03 2012 -0500
mptable: bring sanity back to mptable generation (TRIVIAL)
Remove extra semicolon
Capitalize beginning of printk sentence
Fix detection of multiple ISA-carrying IOAPICs
Fix whitespace issue
Change-Id: I114119b1daf3b472955c0dd00bdc449401789525
Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
src/arch/x86/boot/mpspec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/arch/x86/boot/mpspec.c b/src/arch/x86/boot/mpspec.c
index 010bca1..78996c7 100644
--- a/src/arch/x86/boot/mpspec.c
+++ b/src/arch/x86/boot/mpspec.c
@@ -426,7 +426,7 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
mptable_init(mc, LOCAL_APIC_ADDR);
- smp_write_processors(mc);
+ smp_write_processors(mc);
mptable_write_buses(mc, NULL, &isa_bus);
@@ -443,16 +443,16 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr)
ioapic_config->base);
if (ioapic_config->have_isa_interrupts) {
- if (isaioapic > 1)
+ if (isaioapic >= 0)
printk(BIOS_ERR, "More than one IOAPIC with ISA interrupts?\n");
else
- isaioapic = dev->path.ioapic.ioapic_id;;
+ isaioapic = dev->path.ioapic.ioapic_id;
}
}
if (isaioapic >= 0) {
/* Legacy Interrupts */
- printk(BIOS_DEBUG, "writing ISA IRQs\n");
+ printk(BIOS_DEBUG, "Writing ISA IRQs\n");
mptable_add_isa_interrupts(mc, isa_bus, isaioapic, 0);
}
More information about the coreboot
mailing list