[coreboot] New patch to review for coreboot: 20a412d W83627HF: remove unused function

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Tue Jan 10 22:34:18 CET 2012


Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/533

-gerrit

commit 20a412d99c1a2f2c95a7c5db997c4f6a570a4d1c
Author: Sven Schnelle <svens at stackframe.org>
Date:   Tue Jan 10 22:33:01 2012 +0100

    W83627HF: remove unused function
    
    When CONFIG_EXPERT is set, compilation fails with:
    
    src/superio/winbond/w83627hf/superio.c:61:13: error: ‘w83627hf_16_bit_addr_qual’ defined but not used [-Werror=unused-function]
    cc1: all warnings being treated as errors
    
    This function isn't used in the code, so just remove it.
    
    Change-Id: I117e221fb3c3a20a7d7e7e2e86d7dbfdffc2cbff
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
 src/superio/winbond/w83627hf/superio.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c
index 8ecec62..1d1b169 100644
--- a/src/superio/winbond/w83627hf/superio.c
+++ b/src/superio/winbond/w83627hf/superio.c
@@ -57,20 +57,6 @@ static u8 pnp_read_index(u16 port, u8 reg)
 	return inb(port + 1);
 }
 
-#if CONFIG_EXPERT
-static void w83627hf_16_bit_addr_qual(device_t dev)
-{
-	u8 reg8;
-
-	/* Enable 16 bit address qualification. */
-	pnp_enter_ext_func_mode(dev);
-	reg8 = pnp_read_config(dev, 0x24);
-	reg8 |= (1 << 7);
-	pnp_write_config(dev, 0x24, reg8);
-	pnp_exit_ext_func_mode(dev);
-}
-#endif
-
 static void enable_hwm_smbus(device_t dev)
 {
 	u8 reg8;




More information about the coreboot mailing list