[coreboot] New patch to review for coreboot: 07a8092 pci_ops_conf: Indentation fixes

Vikram Narayanan (vikram186@gmail.com) gerrit at coreboot.org
Tue Jan 24 14:49:50 CET 2012


Vikram Narayanan (vikram186 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/576

-gerrit

commit 07a809248b817de1f1476cf84d4b89f8e98e43eb
Author: Vikram Narayanan <vikram186 at gmail.com>
Date:   Tue Jan 24 19:17:47 2012 +0530

    pci_ops_conf: Indentation fixes
    
    Indentation fixes in src/arch/x86/lib/pci_ops_conf{1,2}.c
    
    Change-Id: I56e8ff6d2ee3a0b871b40577e10c99dea4b3b1bd
    Signed-off-by: Vikram Narayanan <vikram186 at gmail.com>
---
 src/arch/x86/lib/pci_ops_conf1.c |   56 +++++++++++++++++++++----------------
 src/arch/x86/lib/pci_ops_conf2.c |   26 ++++++++++-------
 2 files changed, 47 insertions(+), 35 deletions(-)

diff --git a/src/arch/x86/lib/pci_ops_conf1.c b/src/arch/x86/lib/pci_ops_conf1.c
index 36db54c..266a9cc 100644
--- a/src/arch/x86/lib/pci_ops_conf1.c
+++ b/src/arch/x86/lib/pci_ops_conf1.c
@@ -9,55 +9,63 @@
  */
 
 #if CONFIG_PCI_IO_CFG_EXT == 0
-#define CONFIG_CMD(bus,devfn, where)   (0x80000000 | (bus << 16) | (devfn << 8) | (where & ~3))
+#define CONFIG_CMD(bus,devfn, where)	(0x80000000 | (bus << 16) | \
+										(devfn << 8) | (where & ~3))
 #else
-#define CONFIG_CMD(bus,devfn, where)   (0x80000000 | (bus << 16) | (devfn << 8) | ((where & 0xff) & ~3) | ((where & 0xf00)<<16) )
+#define CONFIG_CMD(bus,devfn, where)	(0x80000000 | (bus << 16) | \
+										(devfn << 8) | ((where & 0xff) & ~3) |\
+										((where & 0xf00)<<16))
 #endif
 
-static uint8_t pci_conf1_read_config8(struct bus *pbus, int bus, int devfn, int where)
+static uint8_t pci_conf1_read_config8(struct bus *pbus, int bus, int devfn,
+				      int where)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		return inb(0xCFC + (where & 3));
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	return inb(0xCFC + (where & 3));
 }
 
-static uint16_t pci_conf1_read_config16(struct bus *pbus, int bus, int devfn, int where)
+static uint16_t pci_conf1_read_config16(struct bus *pbus, int bus, int devfn,
+					int where)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		return inw(0xCFC + (where & 2));
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	return inw(0xCFC + (where & 2));
 }
 
-static uint32_t pci_conf1_read_config32(struct bus *pbus, int bus, int devfn, int where)
+static uint32_t pci_conf1_read_config32(struct bus *pbus, int bus, int devfn,
+					int where)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		return inl(0xCFC);
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	return inl(0xCFC);
 }
 
-static void  pci_conf1_write_config8(struct bus *pbus, int bus, int devfn, int where, uint8_t value)
+static void pci_conf1_write_config8(struct bus *pbus, int bus, int devfn,
+				    int where, uint8_t value)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		outb(value, 0xCFC + (where & 3));
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	outb(value, 0xCFC + (where & 3));
 }
 
-static void pci_conf1_write_config16(struct bus *pbus, int bus, int devfn, int where, uint16_t value)
+static void pci_conf1_write_config16(struct bus *pbus, int bus, int devfn,
+				     int where, uint16_t value)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		outw(value, 0xCFC + (where & 2));
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	outw(value, 0xCFC + (where & 2));
 }
 
-static void pci_conf1_write_config32(struct bus *pbus, int bus, int devfn, int where, uint32_t value)
+static void pci_conf1_write_config32(struct bus *pbus, int bus, int devfn,
+				     int where, uint32_t value)
 {
-		outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
-		outl(value, 0xCFC);
+	outl(CONFIG_CMD(bus, devfn, where), 0xCF8);
+	outl(value, 0xCFC);
 }
 
 #undef CONFIG_CMD
 
-const struct pci_bus_operations pci_cf8_conf1 =
-{
-	.read8  = pci_conf1_read_config8,
+const struct pci_bus_operations pci_cf8_conf1 = {
+	.read8 = pci_conf1_read_config8,
 	.read16 = pci_conf1_read_config16,
 	.read32 = pci_conf1_read_config32,
-	.write8  = pci_conf1_write_config8,
+	.write8 = pci_conf1_write_config8,
 	.write16 = pci_conf1_write_config16,
 	.write32 = pci_conf1_write_config32,
 };
diff --git a/src/arch/x86/lib/pci_ops_conf2.c b/src/arch/x86/lib/pci_ops_conf2.c
index 839f5b4..e89c933 100644
--- a/src/arch/x86/lib/pci_ops_conf2.c
+++ b/src/arch/x86/lib/pci_ops_conf2.c
@@ -12,7 +12,8 @@
 #define FUNC(devfn)		(((devfn & 7) << 1) | 0xf0)
 #define SET(bus,devfn)		outb(FUNC(devfn), 0xCF8); outb(bus, 0xCFA);
 
-static uint8_t pci_conf2_read_config8(struct bus *pbus, int bus, int devfn, int where)
+static uint8_t pci_conf2_read_config8(struct bus *pbus, int bus, int devfn,
+				      int where)
 {
 	uint8_t value;
 	SET(bus, devfn);
@@ -21,7 +22,8 @@ static uint8_t pci_conf2_read_config8(struct bus *pbus, int bus, int devfn, int
 	return value;
 }
 
-static uint16_t pci_conf2_read_config16(struct bus *pbus, int bus, int devfn, int where)
+static uint16_t pci_conf2_read_config16(struct bus *pbus, int bus, int devfn,
+					int where)
 {
 	uint16_t value;
 	SET(bus, devfn);
@@ -30,7 +32,8 @@ static uint16_t pci_conf2_read_config16(struct bus *pbus, int bus, int devfn, in
 	return value;
 }
 
-static uint32_t pci_conf2_read_config32(struct bus *pbus, int bus, int devfn, int where)
+static uint32_t pci_conf2_read_config32(struct bus *pbus, int bus, int devfn,
+					int where)
 {
 	uint32_t value;
 	SET(bus, devfn);
@@ -39,21 +42,24 @@ static uint32_t pci_conf2_read_config32(struct bus *pbus, int bus, int devfn, in
 	return value;
 }
 
-static void pci_conf2_write_config8(struct bus *pbus, int bus, int devfn, int where, uint8_t value)
+static void pci_conf2_write_config8(struct bus *pbus, int bus, int devfn,
+				    int where, uint8_t value)
 {
 	SET(bus, devfn);
 	outb(value, IOADDR(devfn, where));
 	outb(0, 0xCF8);
 }
 
-static void pci_conf2_write_config16(struct bus *pbus, int bus, int devfn, int where, uint16_t value)
+static void pci_conf2_write_config16(struct bus *pbus, int bus, int devfn,
+				     int where, uint16_t value)
 {
 	SET(bus, devfn);
 	outw(value, IOADDR(devfn, where));
 	outb(0, 0xCF8);
 }
 
-static void pci_conf2_write_config32(struct bus *pbus, int bus, int devfn, int where, uint32_t value)
+static void pci_conf2_write_config32(struct bus *pbus, int bus, int devfn,
+				     int where, uint32_t value)
 {
 	SET(bus, devfn);
 	outl(value, IOADDR(devfn, where));
@@ -64,13 +70,11 @@ static void pci_conf2_write_config32(struct bus *pbus, int bus, int devfn, int w
 #undef IOADDR
 #undef FUNC
 
-const struct pci_bus_operations pci_cf8_conf2 =
-{
-	.read8  = pci_conf2_read_config8,
+const struct pci_bus_operations pci_cf8_conf2 = {
+	.read8 = pci_conf2_read_config8,
 	.read16 = pci_conf2_read_config16,
 	.read32 = pci_conf2_read_config32,
-	.write8  = pci_conf2_write_config8,
+	.write8 = pci_conf2_write_config8,
 	.write16 = pci_conf2_write_config16,
 	.write32 = pci_conf2_write_config32,
 };
-




More information about the coreboot mailing list