[coreboot] New patch to review for coreboot: d9c56fa libpayload: Fix EHCI driver

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Tue Jan 31 14:52:13 CET 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/593

-gerrit

commit d9c56faebed52ad5c583c6337d5b01d2c09ed9bd
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Tue Jan 31 14:37:59 2012 +0100

    libpayload: Fix EHCI driver
    
    When converting EHCI to not use bitfields, two offsets were converted
    incorrectly.
    
    Change-Id: I0bb4bad0eee42e54ad4fd53d6c35b107e227c41a
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 payloads/libpayload/drivers/usb/ehci_private.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/ehci_private.h b/payloads/libpayload/drivers/usb/ehci_private.h
index 22fd7b2..6fa5f03 100644
--- a/payloads/libpayload/drivers/usb/ehci_private.h
+++ b/payloads/libpayload/drivers/usb/ehci_private.h
@@ -81,8 +81,8 @@ typedef volatile struct {
 	u32 alt_next_qtd;
 	u32 token;
 #define QTD_STATUS_MASK 0xff
-#define QTD_HALTED (1 << 14)
-#define QTD_ACTIVE (1 << 15)
+#define QTD_HALTED (1 << 6)
+#define QTD_ACTIVE (1 << 7)
 #define QTD_PID_SHIFT 8
 #define QTD_PID_MASK (3 << QTD_PID_SHIFT)
 #define QTD_CERR_SHIFT 10




More information about the coreboot mailing list