[coreboot] New patch to review for coreboot: 53d4234 Move cpus_ready_for_init() to AMD K8

[Kyösti Mälkki]

On Sat, 2012-07-07 at 13:01 +0200, Peter Stuge wrote:
> Kyösti Mälkki wrote:
> >     Move cpus_ready_for_init() to AMD K8
> >     
> >     The function is a noop for all but amd/serengeti_cheetah.
> ..
> > +++ b/src/northbridge/amd/amdk8/northbridge.c
> > @@ -1331,6 +1331,9 @@ static u32 cpu_bus_scan(device_t dev, u32 max)
> >  
> >  static void cpu_bus_init(device_t dev)
> >  {
> > +#if CONFIG_WAIT_BEFORE_CPUS_INIT
> > +	cpus_ready_for_init();
> > +#endif
> >  	initialize_cpus(dev->link_list);
> >  }
> 
> src$ git grep WAIT_BEFORE_CPUS_INIT
> cpu/amd/model_fxx/model_fxx_init.c:#if CONFIG_WAIT_BEFORE_CPUS_INIT
> cpu/x86/Kconfig:config WAIT_BEFORE_CPUS_INIT
> include/cpu/cpu.h:#if !CONFIG_WAIT_BEFORE_CPUS_INIT
> mainboard/amd/pistachio/Kconfig:        select WAIT_BEFORE_CPUS_INIT
> mainboard/amd/serengeti_cheetah/Kconfig:        select WAIT_BEFORE_CPUS_INIT
> mainboard/ibm/e325/Kconfig:     select WAIT_BEFORE_CPUS_INIT
> mainboard/ibm/e326/Kconfig:     select WAIT_BEFORE_CPUS_INIT
> mainboard/iwill/dk8_htx/Kconfig:        select WAIT_BEFORE_CPUS_INIT
> mainboard/iwill/dk8s2/Kconfig:  select WAIT_BEFORE_CPUS_INIT
> mainboard/iwill/dk8x/Kconfig:   select WAIT_BEFORE_CPUS_INIT
> mainboard/msi/ms9652_fam10/Kconfig:config WAIT_BEFORE_CPUS_INIT
> mainboard/technexion/tim8690/Kconfig:   select WAIT_BEFORE_CPUS_INIT
> 
> If it really only applies to serengeti_cheetah then please also move
> the config out of cpu/x86/Kconfig and remove all the selects from
> other boards.

I was hoping that someone who understands use of MEM_TRAIN_SEQ would
show a way to drop WAIT_BEFORE_CPUS_INIT Kconfig altogether.

Kyösti