[coreboot] New patch to review for coreboot: c33f6d0 AMD and GFXUMA : drop redundant use of lb_add_memory_range()

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sun Jul 29 10:07:45 CEST 2012


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1378

-gerrit

commit c33f6d04c9b8c67891002f26038933f00ba8c2fd
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sun Jul 29 10:34:59 2012 +0300

    AMD and GFXUMA : drop redundant use of lb_add_memory_range()
    
    See commit 505414a6cfb2aeef455b5144e4b96fc27f19eb39.
    
    Change-Id: Icc04af9726ae54141581aecc84c40e8aac54591d
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/amd/parmer/mainboard.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/src/mainboard/amd/parmer/mainboard.c b/src/mainboard/amd/parmer/mainboard.c
index dae70c1..0d73a4c 100644
--- a/src/mainboard/amd/parmer/mainboard.c
+++ b/src/mainboard/amd/parmer/mainboard.c
@@ -51,16 +51,6 @@ static void parmer_enable(device_t dev)
 
 int add_mainboard_resources(struct lb_memory *mem)
 {
-	/* UMA is removed from system memory in the northbridge code, but
-	 * in some circumstances we want the memory mentioned as reserved.
-	 */
-	/* TODO: Check out why it was commented. */
-#if CONFIG_GFXUMA
-	printk(BIOS_INFO, "uma_memory_start=0x%llx, uma_memory_size=0x%llx \n",
-	       uma_memory_base, uma_memory_size);
-	lb_add_memory_range(mem, LB_MEM_RESERVED, uma_memory_base,
-			    uma_memory_size);
-#endif
 	return 0;
 }
 struct chip_operations mainboard_ops = {




More information about the coreboot mailing list