[coreboot] New patch to review for coreboot: c3766bb mptable: realign comments with code

Sven Schnelle (svens@stackframe.org) gerrit at coreboot.org
Wed Jun 20 10:38:29 CEST 2012


Sven Schnelle (svens at stackframe.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1115

-gerrit

commit c3766bb391aa1bfa5075c3e62b54f7e8a2f07480
Author: Sven Schnelle <svens at stackframe.org>
Date:   Wed Jun 20 10:38:21 2012 +0200

    mptable: realign comments with code
    
    Change-Id: I4bc90334c7220512607cd5e777ce1f8cc595e2f0
    Signed-off-by: Sven Schnelle <svens at stackframe.org>
---
 util/mptable/mptable.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/util/mptable/mptable.c b/util/mptable/mptable.c
index e284576..5b8a59d 100644
--- a/util/mptable/mptable.c
+++ b/util/mptable/mptable.c
@@ -313,7 +313,6 @@ char *preamble[] = {
 	"",
 	"        smp_write_processors(mc);",
 	"",
-	"",
 	0
 };
 
@@ -809,7 +808,7 @@ static void MPConfigTableHeader(uint32_t pap)
 	}
 
 	/* process all the busses */
-	printf("/*Bus:\t\tBus ID\tType*/\n");
+	printf("\t/* Bus: Bus ID  Type */\n");
 	for (c = count; c; c--) {
 		if (readType() == 1)
 			busEntry();
@@ -817,7 +816,7 @@ static void MPConfigTableHeader(uint32_t pap)
 	}
 
 	/* process all the apics */
-	printf("/*I/O APICs:\tAPIC ID\tVersion\tState\t\tAddress*/\n");
+	printf("\t/* I/O APICs: APIC ID  Version  State  Address */\n");
 	for (c = count; c; c--) {
 		if (readType() == 2)
 			ioApicEntry();
@@ -825,8 +824,7 @@ static void MPConfigTableHeader(uint32_t pap)
 	}
 
 	/* process all the I/O Ints */
-	printf
-	    ("/*I/O Ints:\tType\tPolarity    Trigger\tBus ID\t IRQ\tAPIC ID\tPIN#\n*/");
+	printf("\t/* I/O Ints: Type  Polarity  Trigger  Bus ID  IRQ  APIC ID  PIN#*/ \n");
 	for (c = count; c; c--) {
 		if (readType() == 3)
 			intEntry();
@@ -835,7 +833,7 @@ static void MPConfigTableHeader(uint32_t pap)
 
 	/* process all the Local Ints */
 	printf
-	    ("/*Local Ints:\tType\tPolarity    Trigger\tBus ID\t IRQ\tAPIC ID\tPIN#*/\n");
+	    ("\t/* Local Ints: Type  Polarity  Trigger  Bus ID  IRQ  APIC ID  PIN# */\n");
 	for (c = count; c; c--) {
 		if (readType() == 4)
 			lintEntry();




More information about the coreboot mailing list