[coreboot] New patch to review for coreboot: 0a2af45 libpayload: use correct types in UHCI driver

Anton Kochkov (anton.kochkov@gmail.com) gerrit at coreboot.org
Thu Jun 28 06:22:10 CEST 2012


Anton Kochkov (anton.kochkov at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1144

-gerrit

commit 0a2af45778eb373d2e819b0c3c46e284265813ac
Author: Anton Kochkov <anton.kochkov at gmail.com>
Date:   Thu Jun 28 08:19:41 2012 +0400

    libpayload: use correct types in UHCI driver
    
    As we using 16-bit reading and writing in UHCI drive,
    so all variables related to that must be 16-bit too.
    
    Change-Id: Ib1abb03d054c167512e21f24f3c3da688c7fd01f
    Signed-off-by: Anton Kochkov <anton.kochkov at gmail.com>
---
 payloads/libpayload/drivers/usb/uhci_rh.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/uhci_rh.c b/payloads/libpayload/drivers/usb/uhci_rh.c
index 4674608..a5661b0 100644
--- a/payloads/libpayload/drivers/usb/uhci_rh.c
+++ b/payloads/libpayload/drivers/usb/uhci_rh.c
@@ -86,7 +86,7 @@ uhci_rh_disable_port (usbdev_t *dev, int port)
 		port = PORTSC1;
 	uhci_reg_write16(controller, port,
 			 uhci_reg_read16(controller, port) & ~4);
-	int value;
+	u16 value;
 	/* wait for controller to disable port */
 	/* TOTEST: how long to wait? 100ms for now */
 	int timeout = 200; /* time out after 200 * 500us == 100ms */
@@ -137,7 +137,7 @@ uhci_rh_scanport (usbdev_t *dev, int port)
 static int
 uhci_rh_report_port_changes (usbdev_t *dev)
 {
-	int stored, real;
+	u16 stored, real;
 
 	stored = (RH_INST (dev)->port[0] == -1);
 	real = ((uhci_reg_read16 (dev->controller, PORTSC1) & 1) == 0);




More information about the coreboot mailing list