[coreboot] New patch to review for coreboot: b845313 malloc: size is unsigned, don't test for size < 0

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sun Mar 11 20:48:54 CET 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/780

-gerrit

commit b84531374751d8679d28657935ed3860a4b3851f
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Mar 11 19:30:36 2012 +0100

    malloc: size is unsigned, don't test for size < 0
    
    clang complains
    
    Change-Id: Ifadf73cf377c0d1808e20731803e01101bad7e1d
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/lib/malloc.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/lib/malloc.c b/src/lib/malloc.c
index 3cedc8f..c10750d 100644
--- a/src/lib/malloc.c
+++ b/src/lib/malloc.c
@@ -17,10 +17,6 @@ void *malloc(size_t size)
 
 	MALLOCDBG("%s Enter, size %ld, free_mem_ptr %p\n", __func__, size, free_mem_ptr);
 
-	/* Checking arguments */
-	if (size < 0)
-		die("Error! malloc: size < 0");
-
 	/* Overzealous linker check */
 	if (free_mem_ptr <= 0)
 		die("Error! malloc: Free_mem_ptr <= 0");




More information about the coreboot mailing list