[coreboot] New patch to review for coreboot: f7738ff Add simple PMIO & PMIO2 read/write routines to CIMX wrapper

Martin Roth (martin@se-eng.com) gerrit at coreboot.org
Tue May 1 02:49:19 CEST 2012


Martin Roth (martin at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/981

-gerrit

commit f7738ffdbf221cb4ae80ce3172e8dfa3a54e043d
Author: Martin Roth <martin at se-eng.com>
Date:   Sat Apr 28 10:25:20 2012 -0600

    Add simple PMIO & PMIO2 read/write routines to CIMX wrapper
    
    These are the PMIO & PMIO2 read & write routines from
    src/southbridge/amd/sb800/sb800.c & sb800.h for use in the cimx
    tree.  Currently most platforms using CIMX are calling WritePMIO()
    directly from the src/vendorcode/amd/cimx/sbX00 directories
    instead of using a wrapper function.
    These functions only do byte reads & writes.
    
    Change-Id: I881a6e2d4ddbba3dbdf4dd33e06313fe88b3682a
    Signed-off-by: Martin L Roth <martin at se-eng.com>
---
 src/southbridge/amd/cimx/Makefile.inc |    4 ++
 src/southbridge/amd/cimx/cimx_util.c  |   52 +++++++++++++++++++++++++++++++++
 src/southbridge/amd/cimx/cimx_util.h  |   36 ++++++++++++++++++++++
 3 files changed, 92 insertions(+), 0 deletions(-)

diff --git a/src/southbridge/amd/cimx/Makefile.inc b/src/southbridge/amd/cimx/Makefile.inc
index 80c6378..a9ea8b9 100644
--- a/src/southbridge/amd/cimx/Makefile.inc
+++ b/src/southbridge/amd/cimx/Makefile.inc
@@ -19,3 +19,7 @@
 subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700
 subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB800) += sb800
 subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB900) += sb900
+
+romstage-y += cimx_util.c
+
+ramstage-y += cimx_util.c
diff --git a/src/southbridge/amd/cimx/cimx_util.c b/src/southbridge/amd/cimx/cimx_util.c
new file mode 100755
index 0000000..ca4c86a
--- /dev/null
+++ b/src/southbridge/amd/cimx/cimx_util.c
@@ -0,0 +1,52 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+#include <arch/io.h>
+#include "cimx_util.h"
+
+static void pmio_write_index(u16 port_base, u8 reg, u8 value)
+{
+	outb(reg, port_base);
+	outb(value, port_base + 1);
+}
+
+static u8 pmio_read_index(u16 port_base, u8 reg)
+{
+	outb(reg, port_base);
+	return inb(port_base + 1);
+}
+
+void pm_iowrite(u8 reg, u8 value)
+{
+	pmio_write_index(PM_INDEX, reg, value);
+}
+
+u8 pm_ioread(u8 reg)
+{
+	return pmio_read_index(PM_INDEX, reg);
+}
+
+void pm2_iowrite(u8 reg, u8 value)
+{
+	pmio_write_index(PM2_INDEX, reg, value);
+}
+
+u8 pm2_ioread(u8 reg)
+{
+	return pmio_read_index(PM2_INDEX, reg);
+}
diff --git a/src/southbridge/amd/cimx/cimx_util.h b/src/southbridge/amd/cimx/cimx_util.h
new file mode 100755
index 0000000..4ef534c
--- /dev/null
+++ b/src/southbridge/amd/cimx/cimx_util.h
@@ -0,0 +1,36 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+ */
+
+#ifndef CIMX_UTIL_H
+#define CIMX_UTIL_H
+
+#include <stdint.h>
+
+/* Power management index/data registers */
+#define PM_INDEX	0xcd6
+#define PM_DATA		0xcd7
+#define PM2_INDEX	0xcd0
+#define PM2_DATA	0xcd1
+
+void pm_iowrite(u8 reg, u8 value);
+u8 pm_ioread(u8 reg);
+void pm2_iowrite(u8 reg, u8 value);
+u8 pm2_ioread(u8 reg);
+
+#endif /* CIMX_UTIL_H */




More information about the coreboot mailing list