[coreboot] Patch merged into coreboot/master: aea1621 Fix issue with PCIe power management setup
gerrit at coreboot.org
gerrit at coreboot.org
Tue May 1 21:26:37 CEST 2012
the following patch was just integrated into master:
commit aea1621bd1489a910483d2858dc5810c8d48207e
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Fri Apr 27 10:58:22 2012 -0700
Fix issue with PCIe power management setup
The current early PM setup that attempts to configure dynamic clock
gating relies on PCIe functions to be enabled that may not be.
Instead of reading port 0 or 4 directly to determine the link width
use the register that refelects the soft strapping options as this
will always be available.
Also add a clear register assignment and break for port 0 in the
switch statement instead of falling through to port 4 as that could
end up setting the slot power limit based on port 4 values instead
of based on port 0.
register 0xE1=0x3f and all other root ports should have 0xE1=0x03.
When port 0 and 4 are disabled they will have 0xE1=0x3C before
being disabled by the pch enable handler.
LUMPY default:
00:1c.0 PCI bridge: Intel Corporation Device 1c10 (rev b5)
00:1c.3 PCI bridge: Intel Corporation Device 1c16 (rev b5)
pci_read8 0 0x1c 0 0xe1
0x3f
pci_read8 0 0x1c 3 0xe1
0x03
LUMPY with PCIe port coalesce enabled:
00:1c.0 PCI bridge: Intel Corporation Device 1c10 (rev b5)
00:1c.1 PCI bridge: Intel Corporation Device 1c16 (rev b5)
pci_read8 0 0x1c 0 0xe1
0x3f
pci_read8 0 0x1c 1 0xe1
0x03
Change-Id: I33a37b0ec0c8e570cf5d9dda2c06e0225fee135c
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Build-Tested: build bot (Jenkins) at Tue May 1 06:41:55 2012, giving +1
See http://review.coreboot.org/980 for details.
-gerrit
More information about the coreboot
mailing list