[coreboot] New patch to review for coreboot: 04dcbb0 libpayload: Change "GPIOs" into flags.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Nov 7 00:21:59 CET 2012


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1728

-gerrit

commit 04dcbb0a12e2ef53eb0779f2826100d2746c1bfc
Author: Gabe Black <gabeblack at google.com>
Date:   Mon Oct 1 17:54:03 2012 -0700

    libpayload: Change "GPIOs" into flags.
    
    Some constants which were used to interpret the contents of the coreboot
    tables were moved to the appropriate libpayload header file. The constant which
    describes the maximum length of a GPIO name was renamed to have a CB_ prefix.
    That makes it more obvious what sort of GPIO name it describes, and reduces the
    change of a name collision. It also makes it more consistent with other names
    in that header, although some other exceptions still exist.
    
    Change-Id: I6c0082b3198d34e8a78507fbfac343ee8facf0dc
    Signed-off-by: Gabe Black <gabeblack at google.com>
---
 payloads/libpayload/include/coreboot_tables.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/payloads/libpayload/include/coreboot_tables.h b/payloads/libpayload/include/coreboot_tables.h
index 9251826..14f94cf 100644
--- a/payloads/libpayload/include/coreboot_tables.h
+++ b/payloads/libpayload/include/coreboot_tables.h
@@ -166,12 +166,14 @@ struct cb_framebuffer {
 };
 
 #define CB_TAG_GPIO 0x0013
-#define GPIO_MAX_NAME_LENGTH 16
+#define CB_GPIO_ACTIVE_LOW 0
+#define CB_GPIO_ACTIVE_HIGH 1
+#define CB_GPIO_MAX_NAME_LENGTH 16
 struct cb_gpio {
 	u32 port;
 	u32 polarity;
 	u32 value;
-	u8 name[GPIO_MAX_NAME_LENGTH];
+	u8 name[CB_GPIO_MAX_NAME_LENGTH];
 };
 
 struct cb_gpios {




More information about the coreboot mailing list