[coreboot] Patch merged into coreboot/master: f27d36c Fix cbmem to work on 64 bit platforms
gerrit at coreboot.org
gerrit at coreboot.org
Thu Nov 8 19:39:00 CET 2012
the following patch was just integrated into master:
commit f27d36c361abef8fcbb377a8949067290770571a
Author: Vadim Bendebury <vbendeb at chromium.org>
Date: Wed Aug 29 15:03:09 2012 -0700
Fix cbmem to work on 64 bit platforms
For some reason which I fail to understand, specifying endiannes using
'@' (which means 'native' and should be the same as '<' on x86
platforms) causes cbmem.py to crash the machine on 64 bit systems.
What happens is that the addresses read from various table headers'
struct representations do not make sense, when bogus address gets
passed to get_phys_mem, the crash happens while that function is
executed.
dlaurie@ found out that replacing "@" with "<" in fact fixes the
issue. After some investigation I am just submitting this fix without
much understanding of the root cause.
Change-Id: Iaba9bc72a3f6b1d0407a5f1e3b459ccf5063969d
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
Reviewed-on: http://review.coreboot.org/1715
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
Build-Tested: build bot (Jenkins) at Thu Nov 8 07:13:23 2012, giving +1
See http://review.coreboot.org/1715 for details.
-gerrit
More information about the coreboot
mailing list