[coreboot] Patch merged into coreboot/master: 000bf83 Support better tracking of AP stack usage.

gerrit at coreboot.org gerrit at coreboot.org
Tue Nov 13 02:12:20 CET 2012


the following patch was just integrated into master:
commit 000bf83c934880490d6b1b4c16465cbe7f4f377c
Author: Ronald G. Minnich <rminnich at chromium.org>
Date:   Wed Jun 6 13:00:24 2012 -0700

    Support better tracking of AP stack usage.
    
    This change allows us to figure out how much of the AP stacks we are
    using, as well as to catch any case of an AP overrunning its stack.
    Also, the stack is poisoned, which is a good way to catch programming
    errors -- code should never count on auto variables being zerod.
    
    The stack bases are recorded in a new array, stacks. At the end,
    when all APs are initialized, the stacks are walked and the
    lowest level of the stack that is reached is printed.
    
    Build and boot and look for output like this:
    
    CPU1: stack allocated from 00148000 to 00148ff4:\
    	lowest stack address was 00148c4c
    CPU2: stack allocated from 00147000 to 00147ff4:\
    	lowest stack address was 00147c4c
    CPU3: stack allocated from 00146000 to 00146ff4:\
    	lowest stack address was 00146c4c
    
    Note that we used only about 1K of stack, even though in this
    case we allocated 4K (and in the main branch, we allocate 32K!)
    
    Change-Id: I99b7b9086848496feb3ecd207f64203fa69fadf5
    Signed-off-by: Ronald G. Minnich <rminnich at chromium.org>
    Reviewed-on: http://review.coreboot.org/1818
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Tue Nov 13 01:53:33 2012, giving +1
See http://review.coreboot.org/1818 for details.

-gerrit




More information about the coreboot mailing list